From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Colin King <colin.king@canonical.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Amit Pundir <amit.pundir@linaro.org>,
linux-wireless@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: fdp: remove redundant pointer 'client'
Date: Mon, 23 Jul 2018 11:12:39 +0300 [thread overview]
Message-ID: <cd311a1b46eca9b9238a8071a211a7974154ac31.camel@linux.intel.com> (raw)
In-Reply-To: <20180720181643.21340-1-colin.king@canonical.com>
On Fri, 2018-07-20 at 19:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer 'client' is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'client' set but not used [-Wunused-but-set-
> variable]
Oh, thanks! It seems I had missed this when did a refactoring.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/nfc/fdp/i2c.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/nfc/fdp/i2c.c b/drivers/nfc/fdp/i2c.c
> index 70a970c7375c..5d3ea63e405f 100644
> --- a/drivers/nfc/fdp/i2c.c
> +++ b/drivers/nfc/fdp/i2c.c
> @@ -210,7 +210,6 @@ static int fdp_nci_i2c_read(struct fdp_i2c_phy
> *phy, struct sk_buff **skb)
> static irqreturn_t fdp_nci_i2c_irq_thread_fn(int irq, void *phy_id)
> {
> struct fdp_i2c_phy *phy = phy_id;
> - struct i2c_client *client;
> struct sk_buff *skb;
> int r;
>
> @@ -219,8 +218,6 @@ static irqreturn_t fdp_nci_i2c_irq_thread_fn(int
> irq, void *phy_id)
> return IRQ_NONE;
> }
>
> - client = phy->i2c_dev;
> -
> r = fdp_nci_i2c_read(phy, &skb);
>
> if (r == -EREMOTEIO)
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2018-07-23 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 18:16 [PATCH] nfc: fdp: remove redundant pointer 'client' Colin King
2018-07-23 8:12 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd311a1b46eca9b9238a8071a211a7974154ac31.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=amit.pundir@linaro.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).