From: Sky Zhou <Sky.Zhou@amlogic.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: "linux-amlogic@lists.infradead.org"
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/meson: add size and alignment requirements for dumb buffers
Date: Tue, 16 Apr 2019 10:20:05 +0000 [thread overview]
Message-ID: <cd3674423da344e0a98ca58737efc1f5@amlogic.com> (raw)
In-Reply-To: 20190408090137.2402-1-narmstrong@baylibre.com
On 2019/4/8 17:01, Neil Armstrong wrote:
> The Amlogic SoCs Canvas buffers stride must be aligned on 64bytes
> and overall size should be aligned on PAGE width.
>
> Adds a custom dumb_create op to adds these requirements.
>
> Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
> Suggested-by: Sky Zhou <sky.zhou@amlogic.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/gpu/drm/meson/meson_drv.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index faf1b1b0357c..72b01e6be0d9 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -90,6 +90,18 @@ static irqreturn_t meson_irq(int irq, void *arg)
> return IRQ_HANDLED;
> }
>
> +static int meson_dumb_create(struct drm_file *file, struct drm_device *dev,
> + struct drm_mode_create_dumb *args)
> +{
> + /*
> + * We need 64bytes aligned stride, and PAGE aligned size
> + */
> + args->pitch = ALIGN(DIV_ROUND_UP(args->width * args->bpp, 8), SZ_64);
> + args->size = PAGE_ALIGN(args->pitch * args->height);
> +
> + return drm_gem_cma_dumb_create_internal(file, dev, args);
> +}
> +
> DEFINE_DRM_GEM_CMA_FOPS(fops);
>
> static struct drm_driver meson_driver = {
> @@ -112,7 +124,7 @@ static struct drm_driver meson_driver = {
> .gem_prime_mmap = drm_gem_cma_prime_mmap,
>
> /* GEM Ops */
> - .dumb_create = drm_gem_cma_dumb_create,
> + .dumb_create = meson_dumb_create,
> .gem_free_object_unlocked = drm_gem_cma_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
>
>
Reviewed-by: Sky Zhou <sky.zhou@amlogic.com>
next prev parent reply other threads:[~2019-04-16 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 9:01 [PATCH] drm/meson: add size and alignment requirements for dumb buffers Neil Armstrong
2019-04-16 10:20 ` Sky Zhou [this message]
2019-04-17 18:27 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd3674423da344e0a98ca58737efc1f5@amlogic.com \
--to=sky.zhou@amlogic.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).