From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02077C433E0 for ; Wed, 24 Jun 2020 16:15:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB7F920768 for ; Wed, 24 Jun 2020 16:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kali.org header.i=@kali.org header.b="KZAyUQM1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404999AbgFXQP3 (ORCPT ); Wed, 24 Jun 2020 12:15:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404847AbgFXQPY (ORCPT ); Wed, 24 Jun 2020 12:15:24 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E5CC061795 for ; Wed, 24 Jun 2020 09:15:24 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id 64so2433243oti.5 for ; Wed, 24 Jun 2020 09:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=jTzrkIyHM6YlwLu8OnJrJ+du36mCHfFD6JCb/LI6gk4=; b=KZAyUQM1NXgdHZUgSeRjcVOapIcd47VS8JjBHRQxmSmhwlZeYbF54NTnypSdwR1pHN Yhc9v0tIxyeYVi4C4DInMj8l4+Gd8gqoD42++YiouUN/4Qj5o0cXNvdJSrMgnHP7tGm9 xGX5Jn4FfLMIDa6YavfT5RpjDyjFBbbj4cSHCJQyqganWUimY0gF0arwiNG5UJxAQH3B BBT768EEtIPZqAyUUKC7kFUOndp6hNJg34YQUqIddJlG77838s3hJMbV7oG7caBolQP+ vz8MlJlDA4JotwjNEHhV53SONnuO9Q/kGJgAhiq/0qCL1dO5O6cPBg3teq2+bFYMcB8y KKiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=jTzrkIyHM6YlwLu8OnJrJ+du36mCHfFD6JCb/LI6gk4=; b=cOhhPidcjWMQXrwQ2F0oKVvka9T7+xBx3OybtxUs3AxrxuGuv5YKm7issHfN/IaAp1 blDJnHPKQVa3rGtXrLOcRS0q37PXB8nemslhfVSMVRTo/XxYuUbAVbBRJ3NsrwSnQQE7 yiO7pzZheUemaofu0RO1MsxZrosyMI52KWProLsA8BRm2acdS5zx3R0xKgFFMTW0AFHS 05plXdjlk1h4IGvw0Rb9q+1DFNh7icwVmSSWfZWMhpgNNTBfeqwuqlIqD1Qjqx8pUp2s CS9O5QpE5vRkMP3PTwnNJsZh4DB89YSpMqmo6ikOrio7ONbcA+5d6NIu1OpBQQ2Y6Ifq dCBw== X-Gm-Message-State: AOAM531eGmQLKUWfrhFe6KSI+imS5ytczE0mmxaBKqvumcXAfSYtl8JX C/GjwQGMjg5UI1aGR5X0vtL+ml4NtaPnig== X-Google-Smtp-Source: ABdhPJz58Mv/UXt5ri7/0odUnLorbJuRhuOGQ3NP9QSmUguP0JQTJkEv9LdE/pWvnDwJVvnKUr6wJg== X-Received: by 2002:a9d:64d7:: with SMTP id n23mr7671375otl.240.1593015323041; Wed, 24 Jun 2020 09:15:23 -0700 (PDT) Received: from Steevs-MBP.hackershack.net (cpe-173-175-113-3.satx.res.rr.com. [173.175.113.3]) by smtp.gmail.com with ESMTPSA id a6sm1005413otb.8.2020.06.24.09.15.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2020 09:15:21 -0700 (PDT) Subject: Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support To: Stanley Chu Cc: Kyuho Choi , Avri Altman , Rob Clark , Bjorn Andersson , Asutosh Das , "cang@codeaurora.org" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , linux-arm-msm , Alim Akhtar , "James E.J. Bottomley" , Bean Huo , Tomas Winkler , Colin Ian King , Bart Van Assche , open list References: <3c186284280c37c76cf77bf482dde725359b8a8a.1586382357.git.asutoshd@codeaurora.org> <20200621075539.GK128451@builder.lan> <9d3afac3-c245-a746-b029-77aa66c93f9d@kali.org> <1592963601.3278.1.camel@mtkswgap22> From: Steev Klimaszewski Message-ID: Date: Wed, 24 Jun 2020 11:15:20 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1592963601.3278.1.camel@mtkswgap22> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/20 8:53 PM, Stanley Chu wrote: > Hi Steev, > > Please help try below simple patch to see if above WriteBooster messages > can be eliminated. > > > --- > drivers/scsi/ufs/ufshcd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index f173ad1bd79f..089c0785f0b3 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6985,6 +6985,8 @@ static int ufs_get_device_desc(struct ufs_hba > *hba) > dev_info->wspecversion == 0x220 || > (hba->dev_quirks & UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES)) > ufshcd_wb_probe(hba, desc_buf); > + else > + hba->caps &= ~UFSHCD_CAP_WB_EN; > > /* > * ufshcd_read_string_desc returns size of the string Hi Stanley, That worked. 1. [    0.704775] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg: Unable to find vdd-hba-supply regulator, assuming enabled 2. [    0.704781] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg: Unable to find vccq-supply regulator, assuming enabled 3. [    0.704783] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg: Unable to find vccq2-supply regulator, assuming enabled 4. [    0.705618] ufshcd-qcom 1d84000.ufshc: Found QC Inline Crypto Engine (ICE) v3.1.75 5. [    0.707496] scsi host0: ufshcd 6. [    0.720415] ALSA device list: 7. [    0.720422]   No soundcards found. 8. [    0.734245] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX, TX]: gear=[1, 1], lane[1, 1], pwr[SLOWAUTO_MODE, SLOWAUTO_MODE], rate = 0 9. [    0.845159] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX, TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2 10. [    0.846399] ufshcd-qcom 1d84000.ufshc: ufshcd_find_max_sup_active_icc_level: Regulator capability was not set, actvIccLevel=0 11. [    0.849258] scsi 0:0:0:49488: Well-known LUN    SAMSUNG  KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6 12. [    0.853372] scsi 0:0:0:49476: Well-known LUN    SAMSUNG  KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6 13. [    0.855135] scsi 0:0:0:49456: Well-known LUN    SAMSUNG  KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6 14. [    0.857050] scsi 0:0:0:0: Direct-Access     SAMSUNG  KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6 15. [    0.858297] sd 0:0:0:0: Power-on or device reset occurred 16. [    0.859985] scsi 0:0:0:1: Direct-Access     SAMSUNG  KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6 17. [    0.860702] sd 0:0:0:0: [sda] 29765632 4096-byte logical blocks: (122 GB/114 GiB) (full dmesg output at https://pastebin.com/Pvfqe42P ) I guess you can throw my Tested-by on there. Thanks --Steev