From: Randy Dunlap <rdunlap@infradead.org>
To: Scott Branden <scott.branden@broadcom.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Olof Johansson <olof@lixom.net>,
Desmond Yan <desmond.yan@broadcom.com>
Subject: Re: [PATCH v3] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set
Date: Sun, 31 Jan 2021 18:15:52 -0800 [thread overview]
Message-ID: <cd57b586-9dad-f135-a344-0788826906dc@infradead.org> (raw)
In-Reply-To: <20210131233049.5500-1-scott.branden@broadcom.com>
On 1/31/21 3:30 PM, Scott Branden wrote:
> Correct compile issue if CONFIG_TTY is not set by
> only adding ttyVK devices if CONFIG_BCM_VK_TTY is set.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>
> ---
> Changes since v2:
> - add CONFIG_BCM_VK_TTY
> - add function and stub for bcm_vk_tty_set_irq_enabled
> Changes since v1:
> - add function stubs rather than compiling out code
> ---
> drivers/misc/bcm-vk/Kconfig | 16 ++++++++++++
> drivers/misc/bcm-vk/Makefile | 4 +--
> drivers/misc/bcm-vk/bcm_vk.h | 42 +++++++++++++++++++++++++++++---
> drivers/misc/bcm-vk/bcm_vk_dev.c | 5 ++--
> drivers/misc/bcm-vk/bcm_vk_tty.c | 6 +++++
> 5 files changed, 65 insertions(+), 8 deletions(-)
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
--
~Randy
next prev parent reply other threads:[~2021-02-01 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 23:30 [PATCH v3] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set Scott Branden
2021-02-01 2:15 ` Randy Dunlap [this message]
2021-02-01 7:45 ` Greg Kroah-Hartman
2021-02-01 18:13 ` Scott Branden
2021-02-03 14:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd57b586-9dad-f135-a344-0788826906dc@infradead.org \
--to=rdunlap@infradead.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=desmond.yan@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).