From: Andre Naujoks <nautsch2@gmail.com>
To: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>,
wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: can: Increase tx queue length
Date: Sat, 9 Mar 2019 15:22:00 +0100 [thread overview]
Message-ID: <cd71079c-664f-b1b6-bb21-ecda639ecbed@gmail.com> (raw)
In-Reply-To: <1552140446-31535-1-git-send-email-appana.durga.rao@xilinx.com>
On 3/9/19 3:07 PM, Appana Durga Kedareswara rao wrote:
> While stress testing the CAN interface on xilinx axi can
> in loopback mode getting message "write: no buffer space available"
> Increasing device tx queue length resolved the above mentioned issue.
No need to patch the kernel:
$ ip link set <dev-name> txqueuelen 500
does the same thing.
>
> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> ---
> --> Network devices default tx_queue_len is 1000 but for socket
> can device it is 10 any reason for it??
>
> drivers/net/can/dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
> index c05e4d5..32bd5be 100644
> --- a/drivers/net/can/dev.c
> +++ b/drivers/net/can/dev.c
> @@ -642,7 +642,7 @@ static void can_setup(struct net_device *dev)
> dev->mtu = CAN_MTU;
> dev->hard_header_len = 0;
> dev->addr_len = 0;
> - dev->tx_queue_len = 10;
> + dev->tx_queue_len = 500;
>
> /* New-style flags. */
> dev->flags = IFF_NOARP;
>
next prev parent reply other threads:[~2019-03-09 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 14:07 [PATCH] net: can: Increase tx queue length Appana Durga Kedareswara rao
2019-03-09 14:22 ` Andre Naujoks [this message]
2019-03-09 14:40 ` Appana Durga Kedareswara Rao
2019-03-09 14:56 ` Andre Naujoks
2019-03-09 15:50 ` Toke Høiland-Jørgensen
2019-03-10 5:07 ` Dave Taht
2019-03-10 17:30 ` Oliver Hartkopp
2019-03-15 10:04 ` Appana Durga Kedareswara Rao
2019-03-15 13:53 ` Oliver Hartkopp
2019-03-10 13:36 ` Martin Jerabek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd71079c-664f-b1b6-bb21-ecda639ecbed@gmail.com \
--to=nautsch2@gmail.com \
--cc=appana.durga.rao@xilinx.com \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).