From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29AE3C4727C for ; Tue, 29 Sep 2020 13:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4744208FE for ; Tue, 29 Sep 2020 13:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601386978; bh=5RO0FIB4An+8TnRMhDir9GmpZkMdliSjg1+FOgj7wuU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=sLXn/3HIfVhbXPOF64MHDfCAF76SJlDe+CvP1DqfNFYgrapL9+V4SWYwL5VT8gNIg zmT/bHqSd5UTBz6dIA5yYBxJ2wu+S/gC7IIr8lJbNLuuGfbLn+n7KeVD7srLCo5pii 3KZAk3+s1+P4AaJqxc1sEIYmedtBs++fZ/g7sQtw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730883AbgI2Nm5 (ORCPT ); Tue, 29 Sep 2020 09:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730884AbgI2Nmx (ORCPT ); Tue, 29 Sep 2020 09:42:53 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41AF2C0613D4 for ; Tue, 29 Sep 2020 06:42:52 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id h17so4479150otr.1 for ; Tue, 29 Sep 2020 06:42:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7Re7sYUHoP/OO8RJy6m0dCE8FjQyDvN9idLxneZjSGs=; b=Z34rZ/ds72mfUVTwVAO13Bpz4khcxmzLmZRTJ6BeCzZVGwvFQBFtfTqV+Mw0LWRYNM uCrAI5JhrSTo6VZxNGORq4+uDlbuWvNn0BzZwcj+1vO5F++bvuicz0Q+A30JgXV/f7rA Rk9jpCrpw+utP3CvREty99qb9cv8smpJnWoLw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7Re7sYUHoP/OO8RJy6m0dCE8FjQyDvN9idLxneZjSGs=; b=OSChv19u4J0E2U06VPJJStfO+OyfLJuest4lkdQUPaQsxT9MNoOMpHiHGY83/qDiRi iuLR288TobHB8mPERw7EypMMP4WcvJkIweiR7mqS3OokhoATE+MCUCqqyfQblzpOLUUx IpqQgZxHwzv2dPzrOZA9ag4WVp7cuiQa3s6jB0tO/Czy1W6t64231QM/wkipCc2LfIW8 ymijya1b3owuJdUFLFkAAofQrFV15njXXINn/76maO8wfspw6e4Y9LVuqQZ8Tv1o6GJD kpbHvEyZNvPrPqHpUQCo4QoU4nhnzUBo5lV6z/GpkdSDhEh5CjSw3EPLZgXYDDc7UQOU FIxg== X-Gm-Message-State: AOAM530rEZj7UwBd1niYslJYeaokChazDUIcncFZ5352uA9wGtqfT9DP y2SuRLSTAIutbywYWYElL9Bbuw== X-Google-Smtp-Source: ABdhPJxomgEcCkXHcyd2u2LBzXalo3/5KY6BNqNVB1FRlJIPPq8bhwRXFJ9dfNYvva75m6zRbuIoZQ== X-Received: by 2002:a05:6830:196:: with SMTP id q22mr2688536ota.221.1601386971432; Tue, 29 Sep 2020 06:42:51 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id l4sm993642oie.25.2020.09.29.06.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 06:42:50 -0700 (PDT) Subject: Re: [PATCH 00/18] use semicolons rather than commas to separate statements To: Joe Perches , Julia Lawall , Dan Carpenter , Shuah Khan Cc: Ard Biesheuvel , linux-iio@vger.kernel.org, drbd-dev@tron.linbit.com, =?UTF-8?Q?Valdis_Kl=c4=93tnieks?= , David Lechner , Neil Armstrong , Martin Blumenstingl , linux-wireless@vger.kernel.org, "Rafael J. Wysocki" , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , linux-stm32@st-md-mailman.stormreply.com, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, Linux Crypto Mailing List , linux-amlogic@lists.infradead.org, Thomas Gleixner , ACPI Devel Maling List , openipmi-developer@lists.sourceforge.net, linux-clk@vger.kernel.org, Linux ARM , Jerome Brunet , Shuah Khan References: <1601233948-11629-1-git-send-email-Julia.Lawall@inria.fr> <20200929124108.GY4282@kadam> <5f0d2b20f5088281363bb4a35c5652a2c087f159.camel@perches.com> From: Shuah Khan Message-ID: Date: Tue, 29 Sep 2020 07:42:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5f0d2b20f5088281363bb4a35c5652a2c087f159.camel@perches.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/20 7:34 AM, Joe Perches wrote: > On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote: >> On Tue, 29 Sep 2020, Dan Carpenter wrote: >>> The times where commas are used deliberately to replace curly braces are >>> just evil. Either way the code is cleaner with semi-colons. >> >> I also found exaamples like the following to be particularly unforunate: >> >> fprintf(stderr, >> "page_nr %lu wrong count %Lu %Lu\n", >> page_nr, count, >> count_verify[page_nr]), exit(1); >> >> The exit is very hard to see, unless you know to look for it. > > I sent that patch last month. > https://patchwork.kernel.org/patch/11734877/ > I see what happened. This patch touches lib, cpupower, and selftests. Guess lost in the limbo of who takes it. tools/lib/subcmd/help.c | 10 +- tools/power/cpupower/utils/cpufreq-set.c | 14 +- tools/testing/selftests/vm/gup_benchmark.c | 18 +- tools/testing/selftests/vm/userfaultfd.c | 296 +++++++++++++-------- 4 files changed, 210 insertions(+), 128 deletions(-) I can take it through one of my trees. thanks, -- Shuah