From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: dmaengine <dmaengine@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
viresh kumar <vireshk@kernel.org>, Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH] Revert "dmaengine: dw: Enable runtime PM"
Date: Wed, 3 Feb 2021 20:21:33 +0100 [thread overview]
Message-ID: <cdb0eaaf-5b00-e4af-29c9-2328fd23fbd2@intel.com> (raw)
In-Reply-To: <CAHp75VeuL0d48JBBQrb=twQvtwh4E_oB8Aszy+GtszhNWKqAmg@mail.gmail.com>
On 2021-02-03 6:06 PM, Andy Shevchenko wrote:
> On Wed, Feb 3, 2021 at 5:53 PM Cezary Rojewski
> <cezary.rojewski@intel.com> wrote:
>>
>> This reverts commit 842067940a3e3fc008a60fee388e000219b32632.
>> For some solutions e.g. sound/soc/intel/catpt, DW DMA is part of a
>> compound device (in that very example, domains: ADSP, SSP0, SSP1, DMA0
>> and DMA1 are part of a single entity) rather than being a standalone
>> one. Driver for said device may enlist DMA to transfer data during
>> suspend or resume sequences.
>>
>> Manipulating RPM explicitly in dw's DMA request and release channel
>> functions causes suspend() to also invoke resume() for the exact same
>> device. Similar situation occurs for resume() sequence. Effectively
>> renders device dysfunctional after first suspend() attempt. Revert the
>> change to address the problem.
>
> I kinda had the mixed feelings about this, thanks for the report.
> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Fixes tag?
Noted, sent v2 with updated tag area.
Thanks,
Czarek
prev parent reply other threads:[~2021-02-03 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 15:51 [PATCH] Revert "dmaengine: dw: Enable runtime PM" Cezary Rojewski
2021-02-03 17:06 ` Andy Shevchenko
2021-02-03 17:08 ` Andy Shevchenko
2021-02-03 19:23 ` Cezary Rojewski
2021-02-03 19:21 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdb0eaaf-5b00-e4af-29c9-2328fd23fbd2@intel.com \
--to=cezary.rojewski@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).