From: Martin Vuille <jpmv27@aim.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Kim Phillips <kim.phillips@arm.com>, Jiri Olsa <jolsa@kernel.org>
Cc: "Christian Hansen (chansen3)" <chansen3@cisco.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>,
"Vuille, Martin (Martin)" <vmartin@avaya.com>
Subject: Re: [PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64
Date: Fri, 9 Mar 2018 13:49:50 -0500 [thread overview]
Message-ID: <cde0e6f4-155f-3d7e-8d84-fd482f729976@aim.com> (raw)
In-Reply-To: <20180309182440.GA25111@kernel.org>
Hi,
I made two other submissions that may also have been overlooked:
https://patchwork.kernel.org/patch/10211401/ -- This one has the S-o-B
https://patchwork.kernel.org/patch/10211473/ -- RFC, was looking for comments, has the S-o-B
For https://patchwork.kernel.org/patch/10211483/, I'm not sure how to go about doing a reply to all.
I had some email problems and was cut-off from the list for a while.
MV
On 03/09/18 13:24, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 09, 2018 at 12:07:20PM -0600, Kim Phillips escreveu:
>> On Fri, 9 Mar 2018 12:06:27 -0300
>> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>>
>> Hi Arnaldo,
>>
>>> Em Thu, Mar 08, 2018 at 09:10:30PM -0600, Kim Phillips escreveu:
>>>> Based on prior work:
>>>>
>>>> https://lkml.org/lkml/2014/5/6/395
>>> Thanks, looks good, applying.
>>>
>>> Jean, is everything ok with you on this?
>> By now your email to Jean should have bounced with "The email account
>> that you tried to reach does not exist." Removing Jean from Cc.
>>
>> It seems like you're applying patches. There are a couple that have
>> slipped through the cracks: Can you please take a look at applying them?
>>
>> - "perf tools: Fixing uninitialised variable"
>> https://patchwork.kernel.org/patch/10179381/
> [acme@jouet perf]$ git tag --contains d2785de15f1bd42d613d56bbac5a007e7293b874
> perf-core-for-mingo-4.17-20180216
>
> commit d2785de15f1bd42d613d56bbac5a007e7293b874
> Author: Mathieu Poirier <mathieu.poirier@linaro.org>
> AuthorDate: Mon Feb 12 13:32:37 2018 -0700
> Commit: Arnaldo Carvalho de Melo <acme@redhat.com>
> CommitDate: Fri Feb 16 14:55:40 2018 -0300
>
> perf auxtrace arm: Fixing uninitialised variable
>
> When working natively on arm64 the compiler gets pesky and complains
> that variable 'i' is uninitialised, something that breaks the
> compilation. Here no further checks are needed since variable
> 'found_spe' can only be true if variable 'i' has been initialised as
> part of the for loop.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jin Yao <yao.jin@linux.intel.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Link: http://lkml.kernel.org/r/1518467557-18505-4-git-send-email-mathieu.poirier@linaro.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c
> index 2323581b157d..fa639e3e52ac 100644
> --- a/tools/perf/arch/arm/util/auxtrace.c
> +++ b/tools/perf/arch/arm/util/auxtrace.c
> @@ -68,7 +68,7 @@ struct auxtrace_record
> bool found_spe = false;
> static struct perf_pmu **arm_spe_pmus = NULL;
> static int nr_spes = 0;
> - int i;
> + int i = 0;
>
>> - "perf unwind: Report error from dwfl_attach_state"
>> https://patchwork.kernel.org/patch/10211483/
>> [Martin, I guess it would help if you replied-all that patch and
>> added your signed-off-by.]
> Right, the S-o-B is needed
>
>> - "perf unwind: Unwind with libdw doesn't take symfs into account"
>> https://patchwork.kernel.org/patch/10211599/
> This one has the S-o-B, applying, Jiri, holler if you disagree,
>
> - Arnaldo
>
>> Thanks,
>>
>> Kim
> --
> To unsubscribe from this list: send the line "unsubscribe linux-perf-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-09 18:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <A5E405FE-1BA3-46FC-9A43-CF19A4B369C5@cisco.com>
[not found] ` <20180226142726.cd413c792d0782f77b60a23e@arm.com>
[not found] ` <20180226174040.6998bd3c0a79b2f19c491e4d@arm.com>
[not found] ` <9B701F46-6AEA-48D8-9103-71D35C83776D@cisco.com>
2018-03-09 3:10 ` [PATCH] perf tools arm64: Add libdw DWARF post unwind support for ARM64 Kim Phillips
2018-03-09 15:06 ` Arnaldo Carvalho de Melo
2018-03-09 18:07 ` Kim Phillips
2018-03-09 18:24 ` Arnaldo Carvalho de Melo
2018-03-09 18:49 ` Martin Vuille [this message]
2018-03-09 19:15 ` Kim Phillips
2018-03-09 19:17 ` Martin Vuille
2018-03-09 19:29 ` Arnaldo Carvalho de Melo
2018-03-09 19:35 ` Martin Vuille
2018-03-13 15:23 ` Martin Vuille
2018-03-20 6:20 ` [tip:perf/core] " tip-bot for Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cde0e6f4-155f-3d7e-8d84-fd482f729976@aim.com \
--to=jpmv27@aim.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=chansen3@cisco.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=vmartin@avaya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).