From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 2/3] xen: return xenstore command failures via response instead of rc
Date: Thu, 22 Dec 2016 16:55:13 +0100 [thread overview]
Message-ID: <cdfb649a-1fdd-ef0b-aeb1-fd12281f014f@suse.com> (raw)
In-Reply-To: <9dc05fb2-cb84-d8e7-848b-37fb9c86b782@oracle.com>
On 22/12/16 16:49, Boris Ostrovsky wrote:
> On 12/22/2016 02:19 AM, Juergen Gross wrote:
>> When the xenbus driver does some special handling for a Xenstore
>> command any error condition related to the command should be returned
>> via an error response instead of letting the related write operation
>> fail. Otherwise the user land handler might take wrong decisions
>> assuming the connection to Xenstore is broken.
>
> Do we expect the user to always read the reply if no error code was
> returned?
Absolutely, yes. This is how error reporting of Xenstore is
working.
Juergen
next prev parent reply other threads:[~2016-12-22 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 7:19 [PATCH 0/3] xen: fix some minor bugs and cleanup of xenbus Juergen Gross
2016-12-22 7:19 ` [PATCH 1/3] xen: xenbus driver must not accept invalid transaction ids Juergen Gross
2016-12-22 15:38 ` Boris Ostrovsky
2016-12-22 15:51 ` Juergen Gross
2016-12-22 7:19 ` [PATCH 2/3] xen: return xenstore command failures via response instead of rc Juergen Gross
2016-12-22 15:49 ` Boris Ostrovsky
2016-12-22 15:55 ` Juergen Gross [this message]
2016-12-22 16:00 ` Boris Ostrovsky
2016-12-22 7:19 ` [PATCH 3/3] xen: remove stale xs_input_avail() from header Juergen Gross
2016-12-22 15:50 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdfb649a-1fdd-ef0b-aeb1-fd12281f014f@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).