From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A93FC6FA82 for ; Mon, 26 Sep 2022 06:48:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233696AbiIZGsR (ORCPT ); Mon, 26 Sep 2022 02:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbiIZGsN (ORCPT ); Mon, 26 Sep 2022 02:48:13 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DBC424BCC for ; Sun, 25 Sep 2022 23:48:12 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id j16so9337258lfg.1 for ; Sun, 25 Sep 2022 23:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=xnB45KVy0Jgmqvqqa4iP23q7Nu/qWxhqmCJpHgjco6w=; b=tvjHBcsJmL2XPud8Uer4bOC9txkaora6eR8nrP5h+Vok2cqX4r5azTbIZDe8tapJ4n 8/aWk5uQJw2LMAN5WuRUNdYkwb+u9BWfYbVHjgedq6hZM0ff4cIBnawp4Y6+1bojlGJS 84ov4d8ycMORsBMKRzAwuBv2GeAXpbCANhIrbbns6YEx8w7SbCzCP2X1j6yVw3zwTmnL LivK70YNqTbW0ZCdxY16ouQIDhpNdblenFrXTQcvtzNoqXUmEl8CMFCysAWCBwP1Mctb uDEn3uoi7UMjI181R4AWhgzvE9jkuF+7C63B6556EHDmrx5Gtm/PWUJO4eJC1Sm3ivr1 uXiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=xnB45KVy0Jgmqvqqa4iP23q7Nu/qWxhqmCJpHgjco6w=; b=SwkyHnPKyOqt4Xz9UumNEjD9EWidqHEBW7ABf53uYuJKwJnOukI1Lue2wA/C2e0AnJ 8IBH+UZxwhxeK7NtSPSCl3MfQgezkmHQ39NAGNPiLGlUZIn80F3gPO89VL9OTO7bVxTl ZTol4X41vJmRKUGP84OLH9RswwUw5YcSpUtheuCzwC1zdYa9vhO4Ddx9/HRA+B0MShM9 7uA+W6AU303FqKQtqGafWpx2iOtW3I/RGC2nnrC978z71Te7wHCPG0WexWCAxpag57s+ hWE0RT8aYtLCQ93sDZSA1FErGTNpBQHsUe8MsKwn0fZ4UAt+iMO9U6hZif4lSgLD1bzx MC9A== X-Gm-Message-State: ACrzQf0cT1jWhD/SmKuFHm2Pwkarz86SXrzZbYkyL/w8G9sh7sT8R339 E8G9ocae48aReBuk1Q2kf0WWaw== X-Google-Smtp-Source: AMsMyM5xQLsMt+mT+gwGq0IiKT0zS1FucufeCIblvlZU2Da5RRo5Ahailez9kxVVrHpY5PaOe+tZ0Q== X-Received: by 2002:a05:6512:1092:b0:4a1:de5f:1cc9 with SMTP id j18-20020a056512109200b004a1de5f1cc9mr258895lfg.219.1664174890794; Sun, 25 Sep 2022 23:48:10 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id w6-20020a05651234c600b0049f6484694bsm2440444lfr.161.2022.09.25.23.48.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Sep 2022 23:48:10 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 08:48:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 17/32] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs Content-Language: en-US To: Stephan Gerhold Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Sricharan R , Shawn Guo , Vinod Koul , krishna Lanka , Sivaprakash Murugesan , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220924080459.13084-1-krzysztof.kozlowski@linaro.org> <20220924080459.13084-18-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/09/2022 16:00, Stephan Gerhold wrote: >> + allOf: >> + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" >> + - if: >> + properties: >> + pins: >> + pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" >> + then: >> + required: >> + - function >> > > Is it possible to place this into qcom,tlmm-common.yaml? If the pattern > is only used to make "function" required for GPIOs, then it should not > matter if it matches just the prefix ("^gpio") or the exact set of > allowed GPIO numbers. The definition of the "pins" property will already > take care of validating those. Hm, very good idea. > > Or are there some Qcom SoCs where a GPIO without "function" is valid? Quick look at drivers says there is no such case. I can try adding it to common schema and look for errors. Best regards, Krzysztof