From: Hans Petter Selasky <hps@selasky.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, pb@linuxtv.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 0/3] Fix streaming on/off logic
Date: Tue, 21 Dec 2021 07:34:27 +0100 [thread overview]
Message-ID: <ce0bf57c-7d96-5c33-6ab5-a64d772dee21@selasky.org> (raw)
In-Reply-To: <cover.1632689033.git.mchehab+huawei@kernel.org>
On 9/26/21 22:51, Mauro Carvalho Chehab wrote:
> As discussed on:
> https://github.com/hselasky/webcamd/issues/16
>
> the dib0700 had a regression on Kernel 2.6.39. Such regression didn't
> affect most devices, in practice, as it seems to happen only under
> certain circunstances.
>
> Michael came up with a solution for the issue (already submitted to
> the ML) but let's take the opportunity to do a cleanup, as the resulting
> code was still touching both adapters when an stream off command
> was issued to one adapter, turning on the other one.
>
> After the change, each adapter is idependently controlled by
> a separate bit, as can be shown when its debug message
> is turned on (tested on a dual-adapter device: Hauppauge
> WinTV Nova TD):
>
> [608855.124780] adapter 1, streaming ON: 0f 10 12
> [608868.189827] adapter 0, streaming ON: 0f 10 13
> [608879.584330] adapter 1, streaming OFF: 0f 00 11
> [608887.014772] adapter 0, streaming OFF: 0f 00 10
>
> Mauro Carvalho Chehab (2):
> media: dib0700: cleanup start/stop streaming logic
> media: dib0700: Only touch one bit when start/stop an adapter
>
> Michael Kuron (1):
> media: dib0700: fix undefined behavior in tuner shutdown
>
> drivers/media/usb/dvb-usb/dib0700_core.c | 28 +++++++++++-------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
Were these patches upstreamed yet?
--HPS
next prev parent reply other threads:[~2021-12-21 6:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 20:51 [PATCH 0/3] Fix streaming on/off logic Mauro Carvalho Chehab
2021-09-26 20:51 ` [PATCH 1/3] media: dib0700: fix undefined behavior in tuner shutdown Mauro Carvalho Chehab
2021-09-26 20:51 ` [PATCH 2/3] media: dib0700: cleanup start/stop streaming logic Mauro Carvalho Chehab
2021-09-26 20:51 ` [PATCH 3/3] media: dib0700: Only touch one bit when start/stop an adapter Mauro Carvalho Chehab
2021-12-21 6:34 ` Hans Petter Selasky [this message]
2021-12-22 11:50 ` [PATCH 0/3] Fix streaming on/off logic Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce0bf57c-7d96-5c33-6ab5-a64d772dee21@selasky.org \
--to=hps@selasky.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
--cc=mchehab+huawei@kernel.org \
--cc=pb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).