From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F40C4332F for ; Tue, 14 Sep 2021 05:38:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A592610A6 for ; Tue, 14 Sep 2021 05:38:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239729AbhINFjv (ORCPT ); Tue, 14 Sep 2021 01:39:51 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:33606 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239634AbhINFju (ORCPT ); Tue, 14 Sep 2021 01:39:50 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C30D21FDCA; Tue, 14 Sep 2021 05:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1631597912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eb31X9wNyWIMw+VBDs7ourfgf+3cN+Xonthf0PtZNlY=; b=FfxMinIyIoEC3F5QnwWW8bypmkxglnPteCO1RTKRq5acj2XNp9n+/CD0b+i+A2JrE9igFo i6C+D7j2j2PbLCh8wl9cOEsIsrGTGaG8AY3pArqk3ft5LxKnrHahN2ewbUAklqgT+OdaGi 2wNoNhp5WjHQe2wcRZDk+Hf3aicyksQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1631597912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eb31X9wNyWIMw+VBDs7ourfgf+3cN+Xonthf0PtZNlY=; b=XjrYn6izxG2I/DmE78PtEGYb5HVILBpEXbrWwG+MbZh9/vS2J9Lg91Qm5HRbS1ya4MUQOi pXF3DyeDC6HvKDDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 46F8F13E4A; Tue, 14 Sep 2021 05:38:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gUgrDlg1QGHzTwAAMHmgww (envelope-from ); Tue, 14 Sep 2021 05:38:32 +0000 Subject: Re: [PATCH RESEND v3 04/13] blk-mq: Invert check in blk_mq_update_nr_requests() To: John Garry , axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org References: <1631545950-56586-1-git-send-email-john.garry@huawei.com> <1631545950-56586-5-git-send-email-john.garry@huawei.com> From: Hannes Reinecke Message-ID: Date: Tue, 14 Sep 2021 07:38:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1631545950-56586-5-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/13/21 5:12 PM, John Garry wrote: > It's easier to read: > > if (x) > X; > else > Y; > > over: > > if (!x) > Y; > else > X; > > No functional change intended. > > Signed-off-by: John Garry > Reviewed-by: Ming Lei > --- > block/blk-mq.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer