From: Valentin Schneider <valentin.schneider@arm.com>
To: Liangyan <liangyan.peng@linux.alibaba.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, shanpeic@linux.alibaba.com,
xlpang@linux.alibaba.com, pjt@google.com
Subject: Re: [PATCH] sched/fair: don't assign runtime for throttled cfs_rq
Date: Fri, 16 Aug 2019 18:19:41 +0100 [thread overview]
Message-ID: <ce1b05b1-d4d3-140e-b611-0482fa9fd3f5@arm.com> (raw)
In-Reply-To: <02BC41EE-6653-4473-91D4-CDEE53D8703D@linux.alibaba.com>
On 16/08/2019 16:39, Liangyan wrote:
> Thanks for the feedback.
> Add some debug prints and get below log. It seems that pick_next_task_fair throttle the cfs_rq first, then call put_prev_entity to assign runtime to this cfs_rq.
>
[...]
>
> Regarding the suggested change, i’m not sure whether it is ok to skip the runtime account for curr task.
>
Yeah it's probably pretty stupid. IIRC throttled cfs_rq means frozen
rq_clock, so any subsequent call to update_curr() on a throttled cfs_rq
should lead to an early bailout anyway due to delta_exec <= 0.
next prev parent reply other threads:[~2019-08-16 17:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 18:00 [PATCH] sched/fair: don't assign runtime for throttled cfs_rq Liangyan
2019-08-15 16:36 ` Valentin Schneider
[not found] ` <7C1833A8-27A4-4755-9B1E-335C20207A66@linux.alibaba.com>
2019-08-16 14:02 ` Valentin Schneider
2019-08-16 14:31 ` Valentin Schneider
[not found] ` <02BC41EE-6653-4473-91D4-CDEE53D8703D@linux.alibaba.com>
2019-08-16 17:19 ` Valentin Schneider [this message]
2019-08-19 17:34 ` Valentin Schneider
2019-08-20 10:54 ` [PATCH] sched/fair: Add missing unthrottle_cfs_rq() Valentin Schneider
2019-08-22 9:21 ` Peter Zijlstra
2019-08-22 17:43 ` bsegall
2019-08-22 18:48 ` bsegall
2019-08-22 20:40 ` Valentin Schneider
2019-08-22 21:10 ` Valentin Schneider
2019-08-23 7:22 ` Liangyan
2019-08-23 20:00 ` [PATCH] sched/fair: don't assign runtime for throttled cfs_rq bsegall
2019-08-23 23:19 ` Valentin Schneider
2019-08-26 17:38 ` bsegall
2019-08-27 2:45 ` Liangyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1b05b1-d4d3-140e-b611-0482fa9fd3f5@arm.com \
--to=valentin.schneider@arm.com \
--cc=liangyan.peng@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=shanpeic@linux.alibaba.com \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).