From: Hans de Goede <hdegoede@redhat.com>
To: Chris Chiu <chiu@endlessos.org>,
dvhart@infradead.org, andy@infradead.org
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@endlessos.org,
Daniel Drake <drake@endlessos.org>
Subject: Re: [PATCH] acer-wireless: send an EV_SYN/SYN_REPORT between state changes
Date: Mon, 7 Dec 2020 15:06:14 +0100 [thread overview]
Message-ID: <ce1eaef4-c804-c956-ce24-fa1333100060@redhat.com> (raw)
In-Reply-To: <20201207064322.13992-1-chiu@endlessos.org>
Hi,
On 12/7/20 7:43 AM, Chris Chiu wrote:
> From: Daniel Drake <drake@endlessos.org>
>
> Sending the switch state change twice within the same frame is invalid
> evdev protocol and only works if the client handles keys immediately as
> well. Processing events immediately is incorrect, it forces a fake
> order of events that does not exist on the device.
>
> Recent versions of libinput changed to only process the device state and
> SYN_REPORT time, so now the key event is lost.
>
> Same fix as 'commit <bff5bf9db1c94> ("platform/x86: asus-wireless: send
> an EV_SYN/SYN_REPORT between state changes")'
>
> Signed-off-by: Daniel Drake <drake@endlessos.org>
> Signed-off-by: Chris Chiu <chiu@endlessos.org>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/acer-wireless.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/acer-wireless.c b/drivers/platform/x86/acer-wireless.c
> index e0976180532a..1b5d935d085a 100644
> --- a/drivers/platform/x86/acer-wireless.c
> +++ b/drivers/platform/x86/acer-wireless.c
> @@ -28,6 +28,7 @@ static void acer_wireless_notify(struct acpi_device *adev, u32 event)
> return;
> }
> input_report_key(idev, KEY_RFKILL, 1);
> + input_sync(idev);
> input_report_key(idev, KEY_RFKILL, 0);
> input_sync(idev);
> }
>
prev parent reply other threads:[~2020-12-07 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 6:43 [PATCH] acer-wireless: send an EV_SYN/SYN_REPORT between state changes Chris Chiu
2020-12-07 14:06 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1eaef4-c804-c956-ce24-fa1333100060@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=chiu@endlessos.org \
--cc=drake@endlessos.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessos.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).