From: Xiaoming Ni <nixiaoming@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"yzaikin@google.com" <yzaikin@google.com>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mhocko@suse.com" <mhocko@suse.com>,
"wangle6@huawei.com" <wangle6@huawei.com>
Subject: Re: [PATCH v2] proc_sysctl: fix oops caused by incorrect command parameters.
Date: Mon, 11 Jan 2021 11:14:08 +0800 [thread overview]
Message-ID: <ce276a4e-6be2-cb39-6006-a21bced347f8@huawei.com> (raw)
In-Reply-To: <CAHp75Vfdyh1ad7p_-uqYZPyF78tOB96HKNQVXkOv_yrReo2Mcg@mail.gmail.com>
On 2021/1/9 17:10, Andy Shevchenko wrote:
>
>
> On Friday, January 8, 2021, Xiaoming Ni <nixiaoming@huawei.com
> <mailto:nixiaoming@huawei.com>> wrote:
>
> The process_sysctl_arg() does not check whether val is empty before
> invoking strlen(val). If the command line parameter () is incorrectly
> configured and val is empty, oops is triggered.
>
> For example, "hung_task_panic=1" is incorrectly written as
> "hung_task_panic".
>
> log:
>
>
> Can you drop redundant (not significant) lines from the log to avoid
> noisy commit message?
>
ok,
Thank you for your advice.
I will update it in v3 patch.
Thanks
Xiaoming Ni.
prev parent reply other threads:[~2021-01-11 3:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 2:33 [PATCH v2] proc_sysctl: fix oops caused by incorrect command parameters Xiaoming Ni
2021-01-08 9:21 ` Michal Hocko
2021-01-08 10:01 ` Xiaoming Ni
2021-01-08 11:47 ` Michal Hocko
2021-01-08 19:56 ` Kees Cook
2021-01-08 20:10 ` Michal Hocko
2021-01-09 1:50 ` Andrew Morton
2021-01-11 3:48 ` Xiaoming Ni
2021-01-11 14:21 ` Michal Hocko
2021-01-11 19:50 ` Kees Cook
[not found] ` <CAHp75Vfdyh1ad7p_-uqYZPyF78tOB96HKNQVXkOv_yrReo2Mcg@mail.gmail.com>
2021-01-11 3:14 ` Xiaoming Ni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce276a4e-6be2-cb39-6006-a21bced347f8@huawei.com \
--to=nixiaoming@huawei.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
--cc=wangle6@huawei.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).