From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86DE6C5ACAE for ; Thu, 12 Sep 2019 10:45:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54547208C2 for ; Thu, 12 Sep 2019 10:45:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZjXhY6+F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731149AbfILKpJ (ORCPT ); Thu, 12 Sep 2019 06:45:09 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54010 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730470AbfILKpJ (ORCPT ); Thu, 12 Sep 2019 06:45:09 -0400 Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B51E933A; Thu, 12 Sep 2019 12:45:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1568285107; bh=ySflx1ZVmELycv6C11MLgMeMJ8/ORIvARvZ8QTgVPzI=; h=Reply-To:Subject:From:To:Cc:References:Date:In-Reply-To:From; b=ZjXhY6+FaPpNwSKsQLuMQNYqMGefCghUZ/+IFQGcXkM7qHgYroKb3xpOTIBQ3kXVz VD7xPVUU78sc/gzLAO0hjdF8Ktg2AlAFazWCd5VyGuIZZ+kQBPaTbEi/pvpBtO9DTm tw8iuvL0S1pCmMLdBvsIVvhdY2n0/vthsX3LStE0= Reply-To: kieran.bingham+renesas@ideasonboard.com, kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH] drm: rcar-du: Add r8a77980 support From: Kieran Bingham To: Sergei Shtylyov , linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Geert Uytterhoeven Cc: David Airlie , Daniel Vetter , "open list:DRM DRIVERS FOR RENESAS" , open list References: <20190911192502.16609-1-kieran.bingham+renesas@ideasonboard.com> <70b94265-69f3-d18f-1b67-b5b814723b1b@cogentembedded.com> Openpgp: preference=signencrypt Organization: Ideas on Board Message-ID: Date: Thu, 12 Sep 2019 11:45:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sergei, On 12/09/2019 11:26, Kieran Bingham wrote: > Hi Sergei, > > (pulling in +Geert for his opinion on compatible string usages) > > On 12/09/2019 11:00, Sergei Shtylyov wrote:> Hello! >> >> On 11.09.2019 22:25, Kieran Bingham wrote: >> >>> Add direct support for the r8a77980 (V3H). >>> >>> The V3H shares a common, compatible configuration with the r8a77970 >>> (V3M) so that device info structure is reused. >> >>    Do we really need to add yet another compatible in this case? >> I just added r8a77970 to the compatible prop in the r8a77980 DT. That's why >> a patch like this one didn't get posted by me. Also, the documentation at : Documentation/devicetree/bindings/display/renesas,du.txt already states the the "renesas,du-r8a77980" compatible string is supported thanks to [0], so actually - this addition is a requirement to make the driver match the documentation. [0] 4ffe5aa53791 ("dt-bindings: display: renesas: du: document R8A77980 bindings") >>> Signed-off-by: Kieran Bingham >> [...] >> >> MBR, Sergei >