From: "Shukla, Santosh" <santosh.shukla@amd.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
"Shukla, Santosh" <santosh.shukla@amd.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
mlevitsk@redhat.com
Subject: Re: [PATCHv3 5/8] KVM: SVM: Add VNMI support in inject_nmi
Date: Thu, 25 Aug 2022 19:35:40 +0530 [thread overview]
Message-ID: <ce3c852e-4ee0-36df-383c-0957a6e02a6d@amd.com> (raw)
In-Reply-To: <3752b74b-74e1-00fd-d80d-41104e07fe95@maciej.szmigiero.name>
On 8/25/2022 6:15 PM, Maciej S. Szmigiero wrote:
> On 25.08.2022 12:56, Shukla, Santosh wrote:
>> On 8/24/2022 6:26 PM, Maciej S. Szmigiero wrote:
>>> On 24.08.2022 14:13, Shukla, Santosh wrote:
>>>> Hi Maciej,
>>>>
>>>> On 8/11/2022 2:54 AM, Maciej S. Szmigiero wrote:
>>>>> On 10.08.2022 08:12, Santosh Shukla wrote:
>>>>>> Inject the NMI by setting V_NMI in the VMCB interrupt control. processor
>>>>>> will clear V_NMI to acknowledge processing has started and will keep the
>>>>>> V_NMI_MASK set until the processor is done with processing the NMI event.
>>>>>>
>>>>>> Signed-off-by: Santosh Shukla <santosh.shukla@amd.com>
>>>>>> ---
>>>>>> v3:
>>>>>> - Removed WARN_ON check.
>>>>>>
>>>>>> v2:
>>>>>> - Added WARN_ON check for vnmi pending.
>>>>>> - use `get_vnmi_vmcb` to get correct vmcb so to inject vnmi.
>>>>>>
>>>>>> arch/x86/kvm/svm/svm.c | 7 +++++++
>>>>>> 1 file changed, 7 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
>>>>>> index e260e8cb0c81..8c4098b8a63e 100644
>>>>>> --- a/arch/x86/kvm/svm/svm.c
>>>>>> +++ b/arch/x86/kvm/svm/svm.c
>>>>>> @@ -3479,7 +3479,14 @@ static void pre_svm_run(struct kvm_vcpu *vcpu)
>>>>>> static void svm_inject_nmi(struct kvm_vcpu *vcpu)
>>>>>> {
>>>>>> struct vcpu_svm *svm = to_svm(vcpu);
>>>>>> + struct vmcb *vmcb = NULL;
>>>>>> + if (is_vnmi_enabled(svm)) {
>>>>>
>>>>> I guess this should be "is_vnmi_enabled(svm) && !svm->nmi_l1_to_l2"
>>>>> since if nmi_l1_to_l2 is true then the NMI to be injected originally
>>>>> comes from L1's VMCB12 EVENTINJ field.
>>>>>
>>>>
>>>> Not sure if I understood the case fully.. so trying to sketch scenario here -
>>>> if nmi_l1_to_l2 is true then event is coming from EVTINJ. .which could
>>>> be one of following case -
>>>> 1) L0 (vnmi enabled) and L1 (vnmi disabled)
>>>
>>> As far as I can see in this case:
>>> is_vnmi_enabled() returns whether VMCB02's int_ctl has V_NMI_ENABLE bit set.
>>>
>>
>> For L1 with vnmi disabled case - is_vnmi_enabled()->get_vnmi_vmcb() will return false so the
>> execution path will opt EVTINJ model for re-injection.
>
> I guess by "get_vnmi_vmcb() will return false" you mean it will return NULL,
> since this function returns a pointer, not a bool.
>
Yes, I meant is_vnmi_enabled() will return false if vnmi param is unset.
> I can't see however, how this will happen:
>> static inline struct vmcb *get_vnmi_vmcb(struct vcpu_svm *svm)
>> {
>> if (!vnmi)
>> return NULL;
> ^ "vnmi" variable controls whether L0 uses vNMI,
> so this variable is true in our case
>
No.
In L1 case (vnmi disabled) - vnmi param will be false.
In L0 case (vnmi enabled) - vnmi param will be true.
So in L1 case, is_vnmi_enabled() will return false and
in L0 case will return true.
Thanks,
Santosh
>>
>> if (is_guest_mode(&svm->vcpu))
>> return svm->nested.vmcb02.ptr;
> ^ this should be always non-NULL.
>
> So get_vnmi_vmcb() will return VMCB02 pointer in our case, not NULL...
>
>>
>> Thanks,
>> Santosh
>>
>>> This field in VMCB02 comes from nested_vmcb02_prepare_control() which
>>> in the !nested_vnmi_enabled() case (L1 is not using vNMI) copies these bits
>>> from VMCB01:
>>>> int_ctl_vmcb01_bits |= (V_NMI_PENDING | V_NMI_ENABLE | V_NMI_MASK);
>>>
>>> So in this case (L0 uses vNMI) V_NMI_ENABLE will be set in VMCB01, right?
>>>
>>> This bit will then be copied to VMCB02
>
> ... and due to the above is_vnmi_enabled() will return true, so
> re-injection will attempt to use vNMI instead of EVTINJ (wrong).
>
>>>> 2) L0 & L1 both vnmi disabled.
>>>
>>> This case is ok.
>>>
>>>>
>>>> In both cases the vnmi check will fail for L1 and execution path
>>>> will fall back to default - right?
>>>>
>>>> Thanks,
>>>> Santosh
>>>
>
> Thanks,
> Maciej
next prev parent reply other threads:[~2022-08-25 14:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 6:12 [PATCHv3 0/8] Virtual NMI feature Santosh Shukla
2022-08-10 6:12 ` [PATCHv3 1/8] x86/cpu: Add CPUID feature bit for VNMI Santosh Shukla
2022-08-10 6:12 ` [PATCHv3 2/8] KVM: SVM: Add VNMI bit definition Santosh Shukla
2022-08-10 6:12 ` [PATCHv3 3/8] KVM: SVM: Add VNMI support in get/set_nmi_mask Santosh Shukla
2022-08-10 6:12 ` [PATCHv3 4/8] KVM: SVM: Report NMI not allowed when Guest busy handling VNMI Santosh Shukla
2022-08-10 6:12 ` [PATCHv3 5/8] KVM: SVM: Add VNMI support in inject_nmi Santosh Shukla
2022-08-10 21:24 ` Maciej S. Szmigiero
2022-08-24 12:13 ` Shukla, Santosh
2022-08-24 12:56 ` Maciej S. Szmigiero
2022-08-25 10:56 ` Shukla, Santosh
2022-08-25 12:45 ` Maciej S. Szmigiero
2022-08-25 14:05 ` Shukla, Santosh [this message]
2022-08-25 14:16 ` Maciej S. Szmigiero
2022-08-26 9:35 ` Shukla, Santosh
2022-08-26 12:20 ` Maciej S. Szmigiero
2022-08-26 16:26 ` Shukla, Santosh
2022-08-10 6:12 ` [PATCHv3 6/8] KVM: nSVM: implement nested VNMI Santosh Shukla
2022-08-10 6:12 ` [PATCHv3 7/8] KVM: nSVM: emulate VMEXIT_INVALID case for " Santosh Shukla
2022-08-10 6:12 ` [PATCHv3 8/8] KVM: SVM: Enable VNMI feature Santosh Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce3c852e-4ee0-36df-383c-0957a6e02a6d@amd.com \
--to=santosh.shukla@amd.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).