From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>, jgross@suse.com
Cc: alsa-devel@alsa-project.org,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation
Date: Mon, 17 Dec 2018 09:52:24 -0500 [thread overview]
Message-ID: <ce52ec2e-1b22-8a2f-7f99-d90fcfdbfebd@oracle.com> (raw)
In-Reply-To: <71920419-f0ef-8489-35ff-ff8375cb7361@gmail.com>
On 12/17/18 5:19 AM, Oleksandr Andrushchenko wrote:
> Hello, Juergen, Boris!
>
> As this DRM part of the series is the only one which needs ack/nack
>
> (and it might take quite some time to complete) could we please
>
> merge the patches 1 and 3 now that already have ack/r-b?
>
TBH I am not sure it makes sense to do this without the second patch.
Refactoring (and IIUIC this series is purely refactoring --- is it not?)
is done to reduce amount of code, and with only first and third patch we
end up with quite a significant increase in the number of LoC. (I am
going purely by diffstat)
Of course, the other reason for refactoring is to eliminate code
duplication, but without second patch that will not happen.
-boris
next prev parent reply other threads:[~2018-12-17 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 7:42 [Xen-devel][PATCH v2 1/3] xen: Introduce shared buffer helpers for page directory Oleksandr Andrushchenko
2018-11-30 7:42 ` [Xen-devel][PATCH v2 2/3] drm/xen-front: Use Xen common shared buffer implementation Oleksandr Andrushchenko
2018-12-05 8:20 ` Oleksandr Andrushchenko
2018-12-13 10:16 ` Oleksandr Andrushchenko
2018-12-17 10:19 ` Oleksandr Andrushchenko
2018-12-17 14:52 ` Boris Ostrovsky [this message]
2018-12-17 15:03 ` [Xen-devel] [PATCH " Oleksandr Andrushchenko
2018-12-17 15:26 ` Boris Ostrovsky
2018-12-18 8:47 ` Oleksandr Andrushchenko
2018-12-18 16:15 ` [Xen-devel][PATCH " Noralf Trønnes
2018-12-18 18:31 ` Boris Ostrovsky
2018-12-18 18:48 ` Oleksandr Andrushchenko
2018-11-30 7:42 ` [Xen-devel][PATCH v2 3/3] ALSA: xen-front: " Oleksandr Andrushchenko
2018-12-03 9:36 ` [alsa-devel] " Takashi Iwai
2018-12-03 9:38 ` Oleksandr Andrushchenko
2018-11-30 7:46 ` [Xen-devel][PATCH v2 1/3] xen: Introduce shared buffer helpers for page directory Oleksandr Andrushchenko
2018-12-05 0:28 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce52ec2e-1b22-8a2f-7f99-d90fcfdbfebd@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=andr2000@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).