From: Paolo Bonzini <pbonzini@redhat.com>
To: David Matlack <dmatlack@google.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jmattson@google.com, rkrcmar@redhat.com
Subject: Re: [PATCH 0/4] VMX Capability MSRs
Date: Wed, 23 Nov 2016 12:45:15 +0100 [thread overview]
Message-ID: <ce53d703-fd73-815f-9259-9d35826bea75@redhat.com> (raw)
In-Reply-To: <1479863680-117511-1-git-send-email-dmatlack@google.com>
On 23/11/2016 02:14, David Matlack wrote:
> This patchset includes v2 of "KVM: nVMX: support restore of VMX capability
> MSRs" (patch 1) as well as some additional related patches that came up
> while preparing v2.
>
> Patches 2 and 3 make KVM's emulation of MSR_IA32_VMX_CR{0,4}_FIXED1 more
> accurate. Patch 4 fixes a bug in emulated VM-entry that came up when
> testing patches 2 and 3.
>
> Changes since v1:
> * Support restoring less-capable versions of MSR_IA32_VMX_BASIC,
> MSR_IA32_VMX_CR{0,4}_FIXED{0,1}.
> * Include VMX_INS_OUTS in MSR_IA32_VMX_BASIC initial value.
>
> David Matlack (4):
> KVM: nVMX: support restore of VMX capability MSRs
> KVM: nVMX: fix checks on CR{0,4} during virtual VMX operation
> KVM: nVMX: accurate emulation of MSR_IA32_CR{0,4}_FIXED1
> KVM: nVMX: load GUEST_EFER after GUEST_CR0 during emulated VM-entry
>
> arch/x86/include/asm/vmx.h | 31 ++++
> arch/x86/kvm/vmx.c | 443 +++++++++++++++++++++++++++++++++++++++------
> 2 files changed, 421 insertions(+), 53 deletions(-)
>
The main question is whether patches 2-3 actually make
vmx_restore_fixed0/1_msr unnecessary, otherwise looks great.
It would be nice to have a testcase for patch 4, since it could go in
independently.
Paolo
next prev parent reply other threads:[~2016-11-23 11:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 1:14 [PATCH 0/4] VMX Capability MSRs David Matlack
2016-11-23 1:14 ` [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs David Matlack
2016-11-23 11:44 ` Paolo Bonzini
2016-11-28 21:11 ` David Matlack
2016-11-28 22:48 ` Paolo Bonzini
2016-11-28 22:57 ` David Matlack
2016-11-29 8:01 ` Paolo Bonzini
2016-11-29 17:42 ` David Matlack
2016-11-23 1:14 ` [PATCH 2/4] KVM: nVMX: fix checks on CR{0,4} during virtual VMX operation David Matlack
2016-11-23 11:31 ` Paolo Bonzini
2016-11-28 19:51 ` David Matlack
2016-11-23 1:14 ` [PATCH 3/4] KVM: nVMX: accurate emulation of MSR_IA32_CR{0,4}_FIXED1 David Matlack
2016-11-23 9:06 ` Paolo Bonzini
2016-11-23 19:16 ` David Matlack
2016-11-23 19:24 ` Paolo Bonzini
2016-11-23 22:07 ` David Matlack
2016-11-23 22:11 ` Paolo Bonzini
2016-11-23 23:28 ` David Matlack
2016-11-28 21:51 ` David Matlack
2016-11-23 1:14 ` [PATCH 4/4] KVM: nVMX: load GUEST_EFER after GUEST_CR0 during emulated VM-entry David Matlack
2016-11-23 11:45 ` Paolo Bonzini [this message]
2016-11-28 17:44 ` [PATCH 0/4] VMX Capability MSRs David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce53d703-fd73-815f-9259-9d35826bea75@redhat.com \
--to=pbonzini@redhat.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).