* [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs()
@ 2020-02-11 11:38 Kirill Tkhai
2020-02-11 11:46 ` Vasily Averin
0 siblings, 1 reply; 3+ messages in thread
From: Kirill Tkhai @ 2020-02-11 11:38 UTC (permalink / raw)
To: akpm, guro, vvs, ktkhai, linux-mm, linux-kernel
Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break().
Fixes: bf8d5d52ffe8 "memcg: introduce memory.min"
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
mm/vmscan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index b1863de475fb..f6efe2348ba3 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
continue;
}
memcg_memory_event(memcg, MEMCG_LOW);
- break;
+ /* fallthrough */
case MEMCG_PROT_NONE:
+ mem_cgroup_iter_break(target_memcg, memcg);
/*
* All protection thresholds breached. We may
* still choose to vary the scan pressure
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs()
2020-02-11 11:38 [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs() Kirill Tkhai
@ 2020-02-11 11:46 ` Vasily Averin
2020-02-11 11:48 ` Kirill Tkhai
0 siblings, 1 reply; 3+ messages in thread
From: Vasily Averin @ 2020-02-11 11:46 UTC (permalink / raw)
To: Kirill Tkhai, akpm, guro, linux-mm, linux-kernel
On 2/11/20 2:38 PM, Kirill Tkhai wrote:
> Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break().
>
> Fixes: bf8d5d52ffe8 "memcg: introduce memory.min"
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> ---
> mm/vmscan.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b1863de475fb..f6efe2348ba3 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
> continue;
> }
> memcg_memory_event(memcg, MEMCG_LOW);
> - break;
It is not cycle break, it is switch/case break.
> + /* fallthrough */
> case MEMCG_PROT_NONE:
> + mem_cgroup_iter_break(target_memcg, memcg);
> /*
> * All protection thresholds breached. We may
> * still choose to vary the scan pressure
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs()
2020-02-11 11:46 ` Vasily Averin
@ 2020-02-11 11:48 ` Kirill Tkhai
0 siblings, 0 replies; 3+ messages in thread
From: Kirill Tkhai @ 2020-02-11 11:48 UTC (permalink / raw)
To: Vasily Averin, akpm, guro, linux-mm, linux-kernel
On 11.02.2020 14:46, Vasily Averin wrote:
> On 2/11/20 2:38 PM, Kirill Tkhai wrote:
>> Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break().
>>
>> Fixes: bf8d5d52ffe8 "memcg: introduce memory.min"
>> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>> ---
>> mm/vmscan.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index b1863de475fb..f6efe2348ba3 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc)
>> continue;
>> }
>> memcg_memory_event(memcg, MEMCG_LOW);
>> - break;
>
> It is not cycle break, it is switch/case break.
Oh, I missed this, thanks.
>> + /* fallthrough */
>> case MEMCG_PROT_NONE:
>> + mem_cgroup_iter_break(target_memcg, memcg);
>> /*
>> * All protection thresholds breached. We may
>> * still choose to vary the scan pressure
>>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-11 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 11:38 [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs() Kirill Tkhai
2020-02-11 11:46 ` Vasily Averin
2020-02-11 11:48 ` Kirill Tkhai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).