From: Alexey Minnekhanov <alexeymin@postmarketos.org>
To: Dang Huynh <danct12@riseup.net>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button
Date: Mon, 29 Nov 2021 21:35:15 +0300 [thread overview]
Message-ID: <ce775ef5-2e88-af2b-264b-da77a2e23007@postmarketos.org> (raw)
In-Reply-To: <20211121170449.1124048-1-danct12@riseup.net>
On 11/21/21 8:04 PM, Dang Huynh wrote:
> This enables the volume up key.
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> This patch is a continuation of this series [1]. The other patches in
> the series have been applied and remains this.
>
> Changes in v5:
> - Remove deprecated input-name property.
>
> [1]: https://patchwork.kernel.org/cover/12630601/
>
> arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> index 9a6684922804..6586b8e47483 100644
> --- a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> @@ -9,6 +9,8 @@
> #include "sdm660.dtsi"
> #include "pm660.dtsi"
> #include "pm660l.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/input/gpio-keys.h>
>
> / {
> model = "Xiaomi Redmi Note 7";
> @@ -33,6 +35,17 @@ vph_pwr: vph-pwr-regulator {
> regulator-boot-on;
> };
>
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + volup {
> + label = "Volume Up";
> + gpios = <&pm660l_gpios 7 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + debounce-interval = <15>;
> + };
> + };
> +
> reserved-memory {
> #address-cells = <2>;
> #size-cells = <2>;
>
Nice, works on my Redmi Note 7.
Tested-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
next prev parent reply other threads:[~2021-11-29 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 17:04 [PATCH] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button Dang Huynh
2021-11-29 18:35 ` Alexey Minnekhanov [this message]
2021-12-01 15:12 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce775ef5-2e88-af2b-264b-da77a2e23007@postmarketos.org \
--to=alexeymin@postmarketos.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=danct12@riseup.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).