From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967327AbdEWKMO (ORCPT ); Tue, 23 May 2017 06:12:14 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:37767 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157AbdEWKML (ORCPT ); Tue, 23 May 2017 06:12:11 -0400 Subject: Re: [PATCH 1/3] mfd: lp87565: Add lp87565 PMIC support To: Lee Jones References: <1495197739-17446-1-git-send-email-j-keerthy@ti.com> <1495197739-17446-2-git-send-email-j-keerthy@ti.com> <20170522174806.nnpk5jso7jhgygm3@dell> <26169872-1b43-88d1-3e5b-367b4d446222@ti.com> <20170523065742.44ytkxdagw2wwttz@dell> <20170523084531.oanijbheozgtoufe@dell> CC: , , , , , , , From: Keerthy Message-ID: Date: Tue, 23 May 2017 15:41:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170523084531.oanijbheozgtoufe@dell> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 23 May 2017 02:15 PM, Lee Jones wrote: > On Tue, 23 May 2017, Keerthy wrote: >> On Tuesday 23 May 2017 12:27 PM, Lee Jones wrote: >>> On Tue, 23 May 2017, Keerthy wrote: >>>> On Monday 22 May 2017 11:18 PM, Lee Jones wrote: >>>>> On Fri, 19 May 2017, Keerthy wrote: >>>>> >>>>>> The LP87565 chip is a power management IC for Portable Navigation Systems >>>>>> and Tablet Computing devices. It contains the following components: >>>>>> >>>>>> - Configurable Bucks(Single and multi-phase). >>>>>> - Configurable General Purpose Output Signals (GPO). >>>>>> >>>>>> The LP87565-Q1 variant device uses two 2-phase outputs configuration, >>>>>> Buck0 is master for Buck0/1 output and Buck2 is master for Buck2/3 >>>>>> output. >>>>>> >>>>>> Signed-off-by: Keerthy >>>>>> --- >>>>>> Documentation/devicetree/bindings/mfd/lp87565.txt | 44 ++++ >>>>>> drivers/mfd/Kconfig | 14 ++ >>>>>> drivers/mfd/Makefile | 1 + >>>>>> drivers/mfd/lp87565.c | 103 ++++++++ >>>>>> include/linux/mfd/lp87565.h | 275 ++++++++++++++++++++++ >>>>>> 5 files changed, 437 insertions(+) >>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt >>>>>> create mode 100644 drivers/mfd/lp87565.c >>>>>> create mode 100644 include/linux/mfd/lp87565.h >>>>>> >>> >>> [...] >>> >>>>>> +/* >>>>>> + * Copyright (C) 2017 Texas Instruments Incorporated - http://www.ti.com/ >>>>>> + * >>>>>> + * Author: Keerthy >>>>> >>>>> We usually ask for full "first last" names. >>>> >>>> Keerthy is my full name and i do not have a surname. >>> >>> What is the 'J' for in your email address? >> >> Father's initials. > > Okay. > >>> [...] >>> >>>>>> +static const struct i2c_device_id lp87565_id_table[] = { >>>>>> + { "lp87565-q1", 0 }, >>>>>> + { }, >>>>>> +}; >>>>>> +MODULE_DEVICE_TABLE(i2c, lp87565_id_table); >>>>> >>>>> Is this an OF only driver, or not? >>> >>> You didn't answer my question? >> >> Sorry i replied on top again. It will be an OF only driver. > > Okay, then you don't need this table and you should depend on OF in > the Kconfig file. Okay. Cool thanks for this info. I am seeing this commit: 4895e493f91bff7f96f328b883c7f6448aa6abc6 mfd: Export OF module alias information in missing drivers So no need of i2c_device_id for any of the OF-only mfd drivers? >