From: Marc Zyngier <maz@kernel.org>
To: "qinjian[覃健]" <qinjian@cqplus1.com>
Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
tglx@linutronix.de, p.zabel@pengutronix.de,
linux@armlinux.org.uk, broonie@kernel.org, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
"Wells Lu 呂芳騰" <wells.lu@sunplus.com>
Subject: Re: [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver
Date: Wed, 08 Dec 2021 07:45:11 +0000 [thread overview]
Message-ID: <ce867937861df454823eb703bfd29256@kernel.org> (raw)
In-Reply-To: <39f9b853af7c44cb94421354744512a8@cqplus1.com>
On 2021-12-08 07:15, qinjian[覃健] wrote:
>> > +void sp_intc_set_ext(u32 hwirq, int ext_num)
>> > +{
>> > + sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
>> > +}
>> > +EXPORT_SYMBOL_GPL(sp_intc_set_ext);
>>
>> No way. We don't export random symbols without a good justification,
>> and you didn't give any.
>>
>
> This function called by SP7021 display driver to decide DISPLAY_IRQ
> routing to which parent irq (EXT_INT0 or EXT_INT1).
Based on what? How can a display driver decide which parent is
appropriate? What improvement does this bring?
> In previous patches, which defined in DT, parsed & processed @
> sp_intc_xlate_of()
> From your comment, this is a SW decision. So I removed it from DT &
> intc driver, only
> export this function to access the related intc reg.
If a decision has to be made, it has to be done in the interrupt
controller driver, or rely on the standard API. Exporting random
low level functions to other random drivers is not acceptable.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2021-12-08 7:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 7:34 [PATCH v5 00/10] Add Sunplus SP7021 SoC Support Qin Jian
2021-12-03 7:34 ` [PATCH v5 01/10] dt-bindings: vendor-prefixes: Add Sunplus Qin Jian
2021-12-03 7:34 ` [PATCH v5 02/10] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2021-12-03 7:34 ` [PATCH v5 03/10] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2021-12-03 7:34 ` [PATCH v5 04/10] reset: Add Sunplus " Qin Jian
2021-12-07 8:35 ` Philipp Zabel
2021-12-03 7:34 ` [PATCH v5 05/10] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2021-12-16 6:43 ` Stephen Boyd
2021-12-03 7:34 ` [PATCH v5 06/10] clk: Add Sunplus " Qin Jian
2021-12-16 6:42 ` Stephen Boyd
2021-12-03 7:34 ` [PATCH v5 07/10] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2021-12-03 7:34 ` [PATCH v5 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2021-12-07 9:02 ` Marc Zyngier
2021-12-08 7:15 ` qinjian[覃健]
2021-12-08 7:45 ` Marc Zyngier [this message]
2021-12-08 9:28 ` qinjian[覃健]
2021-12-08 16:02 ` Marc Zyngier
2021-12-03 7:34 ` [PATCH v5 09/10] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2021-12-03 12:59 ` Arnd Bergmann
2021-12-07 7:21 ` qinjian[覃健]
2021-12-07 9:11 ` Arnd Bergmann
2021-12-09 8:49 ` qinjian[覃健]
2021-12-09 9:58 ` Arnd Bergmann
2021-12-09 10:12 ` Ard Biesheuvel
2021-12-03 7:34 ` [PATCH v5 10/10] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2021-12-03 12:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce867937861df454823eb703bfd29256@kernel.org \
--to=maz@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).