From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1348EC19F2B for ; Fri, 29 Jul 2022 06:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234465AbiG2GKo (ORCPT ); Fri, 29 Jul 2022 02:10:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234428AbiG2GKl (ORCPT ); Fri, 29 Jul 2022 02:10:41 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE42E1DA77 for ; Thu, 28 Jul 2022 23:10:40 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id z12-20020a056830128c00b0061c8168d3faso2680884otp.7 for ; Thu, 28 Jul 2022 23:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:content-language:to :cc:references:from:subject:in-reply-to:content-transfer-encoding; bh=77YdUV373K1Bwl63jTp/MrQuJqIC0+oOlc6XVxSF8wM=; b=hpwBKNYnMb+414dNW+3oM8vJwe0iIWzKeqn1ZONZS6zlo4nVsQeXOxNrLSHqUyRCaJ HT8+KHQhSrrAyYaXJCBvscrvgDsKTep0J74e+WPHQg8c+yey3CERvWk/p6P4WcDr/EwK eAbTYyEVjRYcOMV4Vvk/anLeqanp9zVDlg/kAFEVazFrFQ7LA9wwDdRHoXaM4iCUCIwg nv+Ub8Lj5eBKhR+qQ49XTYTF8r5shMUQbV0YiSw3gFyHXiIKz9yvJO0y18BQym+7qRve wO1Xvj5Va3bWCIsq1ZYcYVU+K7e4Fp5z++fGZLISmMz6Nk02oUwQBQ3sNulVepqnobpv IVkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=77YdUV373K1Bwl63jTp/MrQuJqIC0+oOlc6XVxSF8wM=; b=6VFfghDgYvVnQySX2HySKEYrHGJUNphlgjo8uofwWBGWycDSXFWFBmpqs2g8ctWwL4 ZYRKwL3rKuoGAkb6kiNDFggTAe8aLFJwFqdT0dmiGYKpWnY4W4T2xjosSYBmUyx0yCd9 Zle7+lV7iVLdiGwG9OtuUYcimw3i64ys5xdl8WX/jbzVdmvPvspa5HIPGkU1peziB2Mj wrtmgNCJAGyvxOCqR03eAGg523EFZAk9JmR7YG+093w5+6cnsqAfHmVaWvQAUDqewaam mHIpxH0MFCJY3WwWvAjhUDfpYF+kQCcmMipqpB7viVs5iVpeb2qIvmq/Zr9sJQ0z2DhB AFTw== X-Gm-Message-State: AJIora9DkJN2TUtz0/QwdFWakaNhVg7JwliUJ0zxjwgtcK1Zn4eAg/Ma PaTbWD0Bv9vCLfRGfB1MrdzS0o7q7JxOsA== X-Google-Smtp-Source: AGRyM1v85SRTE+GI3yRIc/Eqm/8xmsPl7/gkyzwLM0tdj3c3KCTjrFqh5ADMQ7uMaXvqeNZBwPHPXA== X-Received: by 2002:a05:6830:4488:b0:61c:bee9:36bb with SMTP id r8-20020a056830448800b0061cbee936bbmr897885otv.148.1659075040142; Thu, 28 Jul 2022 23:10:40 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id ay33-20020a056808302100b0032e548d96e0sm1053913oib.23.2022.07.28.23.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 23:10:39 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Thu, 28 Jul 2022 23:10:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Stafford Horne Cc: LKML , Bjorn Helgaas , Arnd Bergmann , Jonas Bonn , Stefan Kristiansson , Palmer Dabbelt , Peter Zijlstra , openrisc@lists.librecores.org References: <20220725020737.1221739-1-shorne@gmail.com> <20220725020737.1221739-3-shorne@gmail.com> <20220729033728.GA2195022@roeck-us.net> From: Guenter Roeck Subject: Re: [PATCH v3 2/3] openrisc: Add pci bus support In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/22 22:50, Stafford Horne wrote: > On Thu, Jul 28, 2022 at 08:37:28PM -0700, Guenter Roeck wrote: >> On Mon, Jul 25, 2022 at 11:07:36AM +0900, Stafford Horne wrote: >>> This patch adds required definitions to allow for PCI buses on OpenRISC. >>> This is being tested on the OpenRISC QEMU virt platform which is in >>> development. >>> >>> OpenRISC does not have IO ports so we keep the definition of >>> IO_SPACE_LIMIT and PIO_RESERVED to be 0. >>> >>> Note, since commit 66bcd06099bb ("parport_pc: Also enable driver for PCI >>> systems") all platforms that support PCI also need to support parallel >>> port. We add a generic header to support compiling parallel port >>> drivers, though they generally will not work as they require IO ports. >>> >>> Signed-off-by: Stafford Horne >> >> This patch results in >> >> Building openrisc:allmodconfig ... failed >> -------------- >> Error log: >> drivers/video/fbdev/riva/fbdev.c: In function 'rivafb_probe': >> drivers/video/fbdev/riva/fbdev.c:2062:42: error: >> passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type >> >> drivers/video/fbdev/nvidia/nvidia.c: In function 'nvidiafb_probe': >> drivers/video/fbdev/nvidia/nvidia.c:1414:20: error: >> passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type >> >> drivers/scsi/aic7xxx/aic7xxx_osm.c: In function 'ahc_platform_free': >> drivers/scsi/aic7xxx/aic7xxx_osm.c:1231:41: error: >> passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type >> >> ... and so on. >> >> Prior to this patch, the code was not enabled because it depends on PCI. > > Hi Guenter, > > Thanks for reporting this. > > It's interesting, I don't get this on the openrisc/for-next branch. > Hmm, weird. I see it all over the place. Complete log is at https://kerneltests.org/builders/next-openrisc-next/builds/1880/steps/buildcommand/logs/stdio if you are interested. > BTW, do you turn off WERROR on the allmodconfig config? I get many warnings > such as the below, but I haven't looked into it much yet: > No, I don't. Disabling it would defeat its purpose. > fs/exec.c: In function 'shift_arg_pages': > fs/exec.c:687:27: error: 'tlb' is used uninitialized [-Werror=uninitialized] > 687 | struct mmu_gather tlb; > | ^~~ > I don't see that in next-20220728. I tried with gcc-11.2 and 11.3. Which compiler do you use ? Thanks, Guenter > I will try to see what is going on in linux-next. > > -Stafford >