From: Yasha Cherikovsky <yasha.che3@gmail.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
linux-mips@linux-mips.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 5/5] MIPS: Add Realtek RTL8186 SoC support
Date: Mon, 01 Oct 2018 11:48:54 +0300 [thread overview]
Message-ID: <ceced0d550bc30d4f3e66d2c7f569c39ca890ce4.camel@gmail.com> (raw)
In-Reply-To: <a7bba9bd-dab3-4f92-465f-e05beee2b9e3@arm.com>
Hi Marc,
On Mon, 2018-10-01 at 09:19 +0100, Marc Zyngier wrote:
> Hi Yasha,
>
> On 30/09/18 15:15, Yasha Cherikovsky wrote:
> > The Realtek RTL8186 SoC is a MIPS based SoC
> > used in some home routers [1][2].
> >
> > The hardware includes Lexra LX5280 CPU with a TLB,
> > two Ethernet controllers, a WLAN controller and more.
> >
> > With this patch, it is possible to successfully boot
> > the kernel and load userspace on the Edimax BR-6204Wg
> > router.
> > Network drivers support will come in future patches.
> >
> > This patch includes:
> > - New MIPS rtl8186 platform
> > - Core platform setup code (mostly DT based)
> > - New Kconfig option
> > - defconfig file
> > - MIPS zboot UART support
> > - RTL8186 interrupt controller driver
> > - RTL8186 timer driver
> > - Device tree files for the RTL8186 SoC and Edimax BR-6204Wg
> > router
> >
> > [1] https://www.linux-mips.org/wiki/Realtek_SOC#Realtek_RTL8186
> > [2] https://wikidevi.com/wiki/Realtek_RTL8186
> >
> > Signed-off-by: Yasha Cherikovsky <yasha.che3@gmail.com>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: Paul Burton <paul.burton@mips.com>
> > Cc: James Hogan <jhogan@kernel.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Jason Cooper <jason@lakedaemon.net>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: linux-mips@linux-mips.org
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > arch/mips/Kbuild.platforms | 1 +
> > arch/mips/Kconfig | 17 ++
> > arch/mips/boot/compressed/uart-16550.c | 5 +
> > arch/mips/boot/dts/Makefile | 1 +
> > arch/mips/boot/dts/realtek/Makefile | 4 +
> > arch/mips/boot/dts/realtek/rtl8186.dtsi | 86 +++++++
> > .../dts/realtek/rtl8186_edimax_br_6204wg.dts | 45 ++++
> > arch/mips/configs/rtl8186_defconfig | 112 +++++++++
> > arch/mips/include/asm/mach-rtl8186/rtl8186.h | 37 +++
> > arch/mips/rtl8186/Makefile | 2 +
> > arch/mips/rtl8186/Platform | 7 +
> > arch/mips/rtl8186/irq.c | 8 +
> > arch/mips/rtl8186/prom.c | 15 ++
> > arch/mips/rtl8186/setup.c | 80 +++++++
> > arch/mips/rtl8186/time.c | 10 +
> > drivers/clocksource/Kconfig | 9 +
> > drivers/clocksource/Makefile | 1 +
> > drivers/clocksource/timer-rtl8186.c | 220
> > ++++++++++++++++++
> > drivers/irqchip/Kconfig | 5 +
> > drivers/irqchip/Makefile | 1 +
> > drivers/irqchip/irq-rtl8186.c | 107 +++++++++
>
> Could you please split this into at least three patches (arch code,
> clocksource, irqchip) to ease the review?
>
> Thanks,
>
> M.
Currently the RTL8186_IRQ and the RTL8186_TIMER Kconfig entries depend on
MACH_RTL8186 (which is added in the MIPS portion of the same patch).
Also, MACH_RTL8186 in MIPS selects these two options.
What is the best way to split that?
Thanks,
Yasha
next prev parent reply other threads:[~2018-10-01 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 14:15 [RFC 0/5] MIPS: Lexra LX5280 CPU + Realtek RTL8186 SoC support Yasha Cherikovsky
2018-09-30 14:15 ` [RFC 1/5] MIPS: Add support for the Lexra LX5280 CPU Yasha Cherikovsky
2018-09-30 14:15 ` [RFC 2/5] dt-binding: timer: Document RTL8186 SoC DT bindings Yasha Cherikovsky
2018-09-30 14:15 ` [RFC 3/5] dt-binding: interrupt-controller: " Yasha Cherikovsky
2018-09-30 14:15 ` [RFC 4/5] dt-binding: mips: Document Realtek " Yasha Cherikovsky
2018-09-30 14:15 ` [RFC 5/5] MIPS: Add Realtek RTL8186 SoC support Yasha Cherikovsky
2018-10-01 8:19 ` Marc Zyngier
2018-10-01 8:48 ` Yasha Cherikovsky [this message]
2018-10-01 9:15 ` Marc Zyngier
2018-10-01 9:24 ` Yasha Cherikovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceced0d550bc30d4f3e66d2c7f569c39ca890ce4.camel@gmail.com \
--to=yasha.che3@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).