From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552CBC48BDF for ; Wed, 9 Jun 2021 00:44:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32723613B6 for ; Wed, 9 Jun 2021 00:44:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230306AbhFIAqI (ORCPT ); Tue, 8 Jun 2021 20:46:08 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:43947 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232607AbhFIAqH (ORCPT ); Tue, 8 Jun 2021 20:46:07 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 62AC358080A; Tue, 8 Jun 2021 20:44:13 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute2.internal (MEProxy); Tue, 08 Jun 2021 20:44:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=ESiqrqHIYM7z6lCPltkbOtCTOZqyomg PzxWqTxX7aGw=; b=bVRKLOURloQOdEKSoaD4tMvkO3qzi7j8RZyWI4pVMP6PkIQ siPo8vytoxrk44Y3TIi/bkNKdN/dcjBtVy4m6arN8XRKA5GI4hGELYDaVWJVfk/+ GdMduLxpGhfxqqA4BjnyJ8leeiNUWtAeTkZqMxKR/MS6ma8gzlEWyQqTXczKnXRp CH0bQqK+HQaBhIdqGB/fwu21sIEG1qN9DjVf4RdlLG3jm6+r2nUKe8/2cixjaulk hXJyoE5cMdhN3KqCl44UCHILQ12nrnO74ElQ+6bZvHQmSXBL7tLQWBWLgGcWv7cQ +nOuMmpJzgBfU1Yq6OXDOcTGhrSB/bsdWo1zbTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ESiqrq HIYM7z6lCPltkbOtCTOZqyomgPzxWqTxX7aGw=; b=OP20yPyWYIpKkn4lyJSIqm XT97jSdlU6qoeVTdz+TUxSWGyCtnrQokuJ4ZwrxHxnbuyj5APnpPs11H1f0rY6vh K8xeeazZT/sV8mX0SYI1ekZn35ZZv1tL2UmQD+lulG3GfpvbAZ2Y5XRZmP5hqd76 cHw/kQleM8mKsm0isU/HFfojTMoqkl7RpTa50kHk59EnfRmrGkqpE2DvA/ode66K 5V+ucTABwJqWPrXU4xzgj/NniEPqu4q2/goFn2+MMx+pg3OvkhSi//FyElx52CZs IfP/qxyk6HO3CQT8Rrx+qmtGjd+botTAqrOov0g00jEAJo1LdLLGFSGImjG5WEqw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedutddgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepvdffudfgudeivdfgffevueelkeekjeekudejfeelgeeivdevhfdtudfh gedvgfehnecuffhomhgrihhnpehinhhfrhgruggvrggurdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvgifsegrjhdrihgu rdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id C3B73AC0062; Tue, 8 Jun 2021 20:44:11 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-519-g27a961944e-fm-20210531.001-g27a96194 Mime-Version: 1.0 Message-Id: In-Reply-To: <20210608102547.4880-4-steven_lee@aspeedtech.com> References: <20210608102547.4880-1-steven_lee@aspeedtech.com> <20210608102547.4880-4-steven_lee@aspeedtech.com> Date: Wed, 09 Jun 2021 10:13:51 +0930 From: "Andrew Jeffery" To: "Steven Lee" , "Linus Walleij" , "Bartosz Golaszewski" , "Rob Herring" , "Joel Stanley" , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list" Cc: "Hongwei Zhang" , "Ryan Chen" , "Billy Tsai" Subject: Re: [PATCH v5 03/10] ARM: dts: aspeed-g6: Add SGPIO node. Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Jun 2021, at 19:55, Steven Lee wrote: > AST2600 supports 2 SGPIO master interfaces one with 128 pins another one > with 80 pins. > > Signed-off-by: Steven Lee > --- > arch/arm/boot/dts/aspeed-g6.dtsi | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi > index f96607b7b4e2..c55baaf94314 100644 > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > @@ -377,6 +377,34 @@ > #interrupt-cells = <2>; > }; > > + sgpiom0: sgpiom@1e780500 { > + #gpio-cells = <2>; > + gpio-controller; > + compatible = "aspeed,ast2600-sgpiom-128"; > + reg = <0x1e780500 0x100>; > + interrupts = ; > + clocks = <&syscon ASPEED_CLK_APB2>; The example in the binding document used ASPEED_CLK_APB. Which is correct? I assume ASPEED_CLK_APB2? > + interrupt-controller; > + bus-frequency = <12000000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sgpm1_default>; > + status = "disabled"; > + }; > + > + sgpiom1: sgpiom@1e780600 { > + #gpio-cells = <2>; > + gpio-controller; > + compatible = "aspeed,ast2600-sgpiom-80"; > + reg = <0x1e780600 0x100>; > + interrupts = ; > + clocks = <&syscon ASPEED_CLK_APB2>; > + interrupt-controller; > + bus-frequency = <12000000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sgpm2_default>; > + status = "disabled"; > + }; > + > gpio1: gpio@1e780800 { > #gpio-cells = <2>; > gpio-controller; > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >