From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards
Date: Fri, 6 May 2016 09:44:29 -0400 [thread overview]
Message-ID: <cef99c21-3886-c055-05bf-cd04e3b588b3@osg.samsung.com> (raw)
In-Reply-To: <1461871311-18344-1-git-send-email-javier@osg.samsung.com>
Hello Krzysztof,
On 04/28/2016 03:21 PM, Javier Martinez Canillas wrote:
> The MFC nodes with the memory regions reserved for memory allocations
> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS.
>
> This causes the s5p-mfc driver probe to fail with the following error:
>
> [ 4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device
> [ 4.216163] s5p-mfc: probe of 11000000.codec failed with error -12
>
> Add the missing nodes so the driver probes and the {en,de}coder video
> nodes are registered correctly:
>
> [ 4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4
> [ 4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index b644858231b6..f9d2e4f1a0e0 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -694,6 +694,11 @@
> status = "okay";
> };
>
> +&mfc {
> + samsung,mfc-r = <0x43000000 0x800000>;
> + samsung,mfc-l = <0x51000000 0x800000>;
> +};
> +
> &mmc_0 {
> status = "okay";
> num-slots = <1>;
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index 6ba9aec15485..62ceb89e073f 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -669,6 +669,11 @@
> status = "okay";
> };
>
> +&mfc {
> + samsung,mfc-r = <0x43000000 0x800000>;
> + samsung,mfc-l = <0x51000000 0x800000>;
> +};
> +
> &mmc_0 {
> status = "okay";
> num-slots = <1>;
>
Any comments about this patch?
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-05-06 13:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 19:21 [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards Javier Martinez Canillas
2016-05-06 13:44 ` Javier Martinez Canillas [this message]
2016-05-06 13:58 ` Krzysztof Kozlowski
2016-05-06 14:12 ` Javier Martinez Canillas
2016-05-06 14:13 ` Krzysztof Kozlowski
2016-05-25 8:33 ` pankaj.dubey
2016-05-25 15:02 ` Javier Martinez Canillas
2016-05-26 3:43 ` pankaj.dubey
2016-05-26 7:45 ` Javier Martinez Canillas
2016-05-26 9:10 ` pankaj.dubey
2016-05-26 12:14 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cef99c21-3886-c055-05bf-cd04e3b588b3@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).