From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20BCBC56202 for ; Fri, 13 Nov 2020 19:46:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD1642223F for ; Fri, 13 Nov 2020 19:46:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="WeXwaIFz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726374AbgKMTqt (ORCPT ); Fri, 13 Nov 2020 14:46:49 -0500 Received: from z5.mailgun.us ([104.130.96.5]:33716 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbgKMTqt (ORCPT ); Fri, 13 Nov 2020 14:46:49 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605296809; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=XQR2DizaqucPQpeF3S73VOOHiAuFQxlGivhbcgxWTSo=; b=WeXwaIFzRU9eFqtUVYFlQF5nEGHW2Vz8yUcDEfOhKKcwAQEkDQ3d5ddwiOsswmzHgkJssJJf 72q37v+To+A6crgP/CiLqIWZXE3J30GMI0zeZGPd5Wunim2scyhgl+rq5WOt7QEjAN03Sl8I R76ZGqkNnfEcaUQQlcKAQNy9bk4= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5faee2a1135ce186e9fc298a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 13 Nov 2020 19:46:41 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 18F88C433CB; Fri, 13 Nov 2020 19:46:41 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 57163C433C6; Fri, 13 Nov 2020 19:46:40 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 13 Nov 2020 11:46:40 -0800 From: abhinavk@codeaurora.org To: Lee Jones Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , Sean Paul Subject: Re: [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en, dis}able()' static In-Reply-To: <20201113134938.4004947-36-lee.jones@linaro.org> References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-36-lee.jones@linaro.org> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-13 05:49, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:299:5: warning: no previous > prototype for ‘mdp5_disable’ [-Wmissing-prototypes] > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:319:5: warning: no previous > prototype for ‘mdp5_enable’ [-Wmissing-prototypes] > > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Thomas Zimmermann > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index b3eecf8694771..15aed45022bc8 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -296,7 +296,7 @@ static const struct mdp_kms_funcs kms_funcs = { > .set_irqmask = mdp5_set_irqmask, > }; > > -int mdp5_disable(struct mdp5_kms *mdp5_kms) > +static int mdp5_disable(struct mdp5_kms *mdp5_kms) > { > DBG(""); > > @@ -316,7 +316,7 @@ int mdp5_disable(struct mdp5_kms *mdp5_kms) > return 0; > } > > -int mdp5_enable(struct mdp5_kms *mdp5_kms) > +static int mdp5_enable(struct mdp5_kms *mdp5_kms) > { > DBG("");