From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162764AbdD1Be2 (ORCPT ); Thu, 27 Apr 2017 21:34:28 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:59794 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939202AbdD1BeU (ORCPT ); Thu, 27 Apr 2017 21:34:20 -0400 X-IronPort-AV: E=Sophos;i="5.37,386,1488870000"; d="scan'208";a="2122526" Subject: Re: [PATCH 3/3] ARM: at91: pm: fallback to slowclock when backup mode fails To: Alexandre Belloni , Nicolas Ferre CC: , References: <20170426160419.22401-1-alexandre.belloni@free-electrons.com> <20170426160419.22401-3-alexandre.belloni@free-electrons.com> From: "Yang, Wenyou" Message-ID: Date: Fri, 28 Apr 2017 09:34:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170426160419.22401-3-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/4/27 0:04, Alexandre Belloni wrote: > If the backup sram allocation fails, ensure we can suspend by falling back > to the usual slow clock mode. > > Signed-off-by: Alexandre Belloni Acked-by: Wenyou Yang > --- > arch/arm/mach-at91/pm.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > index d08f032f9d94..02823d8f3ada 100644 > --- a/arch/arm/mach-at91/pm.c > +++ b/arch/arm/mach-at91/pm.c > @@ -519,24 +519,30 @@ static void __init at91_pm_bu_sram_init(void) > > if (!pdev) { > pr_warn("%s: failed to find securam device!\n", __func__); > - return; > + goto fallback; > } > > sram_pool = gen_pool_get(&pdev->dev, NULL); > if (!sram_pool) { > pr_warn("%s: securam pool unavailable!\n", __func__); > - return; > + goto fallback; > } > > pm_bu = (void *)gen_pool_alloc(sram_pool, sizeof(struct at91_pm_bu)); > if (!pm_bu) { > pr_warn("%s: unable to alloc securam!\n", __func__); > - return; > + goto fallback; > } > > pm_bu->suspended = 0; > pm_bu->canary = virt_to_phys(&canary); > pm_bu->resume = virt_to_phys(cpu_resume); > + > +fallback: > + if (pm_data.standby_mode == AT91_PM_BACKUP) > + pm_data.standby_mode = AT91_PM_SLOW_CLOCK; > + if (pm_data.suspend_mode != AT91_PM_BACKUP) > + pm_data.suspend_mode = AT91_PM_SLOW_CLOCK; > } > > struct pmc_info { Best Regards, Wenyou Yang