* [PATCH v2] init: Do not select DEBUG_KERNEL by default
@ 2019-04-10 22:42 Sinan Kaya
2019-04-10 22:58 ` Kees Cook
0 siblings, 1 reply; 11+ messages in thread
From: Sinan Kaya @ 2019-04-10 22:42 UTC (permalink / raw)
To: linux-kernel
Cc: Sinan Kaya, Masahiro Yamada, Andrew Morton, Kees Cook,
Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du
We can't seem to have a kernel with CONFIG_EXPERT set but
CONFIG_DEBUG_KERNEL unset these days.
While some of the features under the CONFIG_EXPERT require
CONFIG_DEBUG_KERNEL, it doesn't apply for all features.
It looks like CONFIG_KALLSYMS_ALL is the only feature that
requires CONFIG_DEBUG_KERNEL.
Select CONFIG_EXPERT when CONFIG_DEBUG is chosen but you can
still choose CONFIG_EXPERT without CONFIG_DEBUG.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
init/Kconfig | 2 --
lib/Kconfig.debug | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 4592bf7997c0..37e10a8391a3 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1206,8 +1206,6 @@ config BPF
menuconfig EXPERT
bool "Configure standard kernel features (expert users)"
- # Unhide debug options, to make the on-by-default options visible
- select DEBUG_KERNEL
help
This option allows certain base kernel options and settings
to be disabled or tweaked. This is for specialized
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 0d9e81779e37..9fbf3499ec8d 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -434,6 +434,7 @@ config MAGIC_SYSRQ_SERIAL
config DEBUG_KERNEL
bool "Kernel debugging"
+ default EXPERT
help
Say Y here if you are developing drivers or trying to debug and
identify kernel problems.
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-10 22:42 [PATCH v2] init: Do not select DEBUG_KERNEL by default Sinan Kaya
@ 2019-04-10 22:58 ` Kees Cook
2019-04-10 23:22 ` Josh Triplett
0 siblings, 1 reply; 11+ messages in thread
From: Kees Cook @ 2019-04-10 22:58 UTC (permalink / raw)
To: Sinan Kaya
Cc: LKML, Masahiro Yamada, Andrew Morton, Kees Cook,
Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Josh Triplett, Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> We can't seem to have a kernel with CONFIG_EXPERT set but
> CONFIG_DEBUG_KERNEL unset these days.
>
> While some of the features under the CONFIG_EXPERT require
> CONFIG_DEBUG_KERNEL, it doesn't apply for all features.
>
> It looks like CONFIG_KALLSYMS_ALL is the only feature that
> requires CONFIG_DEBUG_KERNEL.
>
> Select CONFIG_EXPERT when CONFIG_DEBUG is chosen but you can
Typo: CONFIG_DEBUG_KERNEL
> still choose CONFIG_EXPERT without CONFIG_DEBUG.
same.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
But with those fixed, looks good to me. Adding Josh (and others) to CC
since he originally added the linkage to EXPERT in commit
f505c553dbe2.
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> init/Kconfig | 2 --
> lib/Kconfig.debug | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 4592bf7997c0..37e10a8391a3 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1206,8 +1206,6 @@ config BPF
>
> menuconfig EXPERT
> bool "Configure standard kernel features (expert users)"
> - # Unhide debug options, to make the on-by-default options visible
> - select DEBUG_KERNEL
> help
> This option allows certain base kernel options and settings
> to be disabled or tweaked. This is for specialized
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 0d9e81779e37..9fbf3499ec8d 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -434,6 +434,7 @@ config MAGIC_SYSRQ_SERIAL
>
> config DEBUG_KERNEL
> bool "Kernel debugging"
> + default EXPERT
> help
> Say Y here if you are developing drivers or trying to debug and
> identify kernel problems.
> --
> 2.21.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-10 22:58 ` Kees Cook
@ 2019-04-10 23:22 ` Josh Triplett
2019-04-10 23:24 ` Kees Cook
0 siblings, 1 reply; 11+ messages in thread
From: Josh Triplett @ 2019-04-10 23:22 UTC (permalink / raw)
To: Kees Cook, Sinan Kaya
Cc: LKML, Masahiro Yamada, Andrew Morton, Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On April 10, 2019 3:58:55 PM PDT, Kees Cook <keescook@chromium.org> wrote:
>On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya <okaya@kernel.org> wrote:
>>
>> We can't seem to have a kernel with CONFIG_EXPERT set but
>> CONFIG_DEBUG_KERNEL unset these days.
>>
>> While some of the features under the CONFIG_EXPERT require
>> CONFIG_DEBUG_KERNEL, it doesn't apply for all features.
>>
>> It looks like CONFIG_KALLSYMS_ALL is the only feature that
>> requires CONFIG_DEBUG_KERNEL.
>>
>> Select CONFIG_EXPERT when CONFIG_DEBUG is chosen but you can
>
>Typo: CONFIG_DEBUG_KERNEL
>
>> still choose CONFIG_EXPERT without CONFIG_DEBUG.
>
>same.
>
>>
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>
>But with those fixed, looks good to me. Adding Josh (and others) to CC
>since he originally added the linkage to EXPERT in commit
>f505c553dbe2.
CONFIG_DEBUG_KERNEL shouldn't affect code generation in any way; it should only make more options appear in kconfig. I originally added this to ensure that features you might want to *disable* aren't hidden, as part of the tinification effort.
What specific problem does having CONFIG_DEBUG_KERNEL enabled cause for you? I'd still prefer to have a single switch for "don't hide things I might want to disable", rather than several.
This would also need checking to make sure it doesn't grow tinyconfig.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-10 23:22 ` Josh Triplett
@ 2019-04-10 23:24 ` Kees Cook
2019-04-11 3:02 ` Josh Triplett
0 siblings, 1 reply; 11+ messages in thread
From: Kees Cook @ 2019-04-10 23:24 UTC (permalink / raw)
To: Josh Triplett
Cc: Sinan Kaya, LKML, Masahiro Yamada, Andrew Morton,
Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett <josh@joshtriplett.org> wrote:
>
> On April 10, 2019 3:58:55 PM PDT, Kees Cook <keescook@chromium.org> wrote:
> >On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya <okaya@kernel.org> wrote:
> >>
> >> We can't seem to have a kernel with CONFIG_EXPERT set but
> >> CONFIG_DEBUG_KERNEL unset these days.
> >>
> >> While some of the features under the CONFIG_EXPERT require
> >> CONFIG_DEBUG_KERNEL, it doesn't apply for all features.
> >>
> >> It looks like CONFIG_KALLSYMS_ALL is the only feature that
> >> requires CONFIG_DEBUG_KERNEL.
> >>
> >> Select CONFIG_EXPERT when CONFIG_DEBUG is chosen but you can
> >
> >Typo: CONFIG_DEBUG_KERNEL
> >
> >> still choose CONFIG_EXPERT without CONFIG_DEBUG.
> >
> >same.
> >
> >>
> >> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> >
> >But with those fixed, looks good to me. Adding Josh (and others) to CC
> >since he originally added the linkage to EXPERT in commit
> >f505c553dbe2.
>
> CONFIG_DEBUG_KERNEL shouldn't affect code generation in any way; it should only make more options appear in kconfig. I originally added this to ensure that features you might want to *disable* aren't hidden, as part of the tinification effort.
>
> What specific problem does having CONFIG_DEBUG_KERNEL enabled cause for you? I'd still prefer to have a single switch for "don't hide things I might want to disable", rather than several.
See earlier in the thread: code generation depends on
CONFIG_DEBUG_KERNEL now unfortunately.
--
Kees Cook
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-10 23:24 ` Kees Cook
@ 2019-04-11 3:02 ` Josh Triplett
2019-04-11 3:13 ` Sinan Kaya
2019-04-11 3:44 ` Randy Dunlap
0 siblings, 2 replies; 11+ messages in thread
From: Josh Triplett @ 2019-04-11 3:02 UTC (permalink / raw)
To: Kees Cook
Cc: Sinan Kaya, LKML, Masahiro Yamada, Andrew Morton,
Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On April 10, 2019 4:24:18 PM PDT, Kees Cook <keescook@chromium.org> wrote:
>On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett <josh@joshtriplett.org>
>wrote:
>>
>> On April 10, 2019 3:58:55 PM PDT, Kees Cook <keescook@chromium.org>
>wrote:
>> >On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya <okaya@kernel.org> wrote:
>> >>
>> >> We can't seem to have a kernel with CONFIG_EXPERT set but
>> >> CONFIG_DEBUG_KERNEL unset these days.
>> >>
>> >> While some of the features under the CONFIG_EXPERT require
>> >> CONFIG_DEBUG_KERNEL, it doesn't apply for all features.
>> >>
>> >> It looks like CONFIG_KALLSYMS_ALL is the only feature that
>> >> requires CONFIG_DEBUG_KERNEL.
>> >>
>> >> Select CONFIG_EXPERT when CONFIG_DEBUG is chosen but you can
>> >
>> >Typo: CONFIG_DEBUG_KERNEL
>> >
>> >> still choose CONFIG_EXPERT without CONFIG_DEBUG.
>> >
>> >same.
>> >
>> >>
>> >> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> >
>> >But with those fixed, looks good to me. Adding Josh (and others) to
>CC
>> >since he originally added the linkage to EXPERT in commit
>> >f505c553dbe2.
>>
>> CONFIG_DEBUG_KERNEL shouldn't affect code generation in any way; it
>should only make more options appear in kconfig. I originally added
>this to ensure that features you might want to *disable* aren't hidden,
>as part of the tinification effort.
>>
>> What specific problem does having CONFIG_DEBUG_KERNEL enabled cause
>for you? I'd still prefer to have a single switch for "don't hide
>things I might want to disable", rather than several.
>
>See earlier in the thread: code generation depends on
>CONFIG_DEBUG_KERNEL now unfortunately.
Then let's fix *that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-11 3:02 ` Josh Triplett
@ 2019-04-11 3:13 ` Sinan Kaya
2019-04-11 22:16 ` Josh Triplett
2019-04-11 3:44 ` Randy Dunlap
1 sibling, 1 reply; 11+ messages in thread
From: Sinan Kaya @ 2019-04-11 3:13 UTC (permalink / raw)
To: Josh Triplett, Kees Cook
Cc: LKML, Masahiro Yamada, Andrew Morton, Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On 4/10/2019 11:02 PM, Josh Triplett wrote:
> Then let's fix*that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this.
I think we have to do both. We need to go after the users as well as
solve the immediate problem per this patch.
As Mathieu identified, CONFIG_DEBUG_KERNEL is being used all over the
place and getting subsystem owners to remove let alone add a check
to checkpatch is just going to take time.
Please let us know if you are OK with this plan.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-11 3:02 ` Josh Triplett
2019-04-11 3:13 ` Sinan Kaya
@ 2019-04-11 3:44 ` Randy Dunlap
1 sibling, 0 replies; 11+ messages in thread
From: Randy Dunlap @ 2019-04-11 3:44 UTC (permalink / raw)
To: Josh Triplett, Kees Cook
Cc: Sinan Kaya, LKML, Masahiro Yamada, Andrew Morton,
Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Mikulas Patocka,
Robin Murphy, Tetsuo Handa, Changbin Du, Frederic Weisbecker,
Sam Ravnborg, Ingo Molnar
On 4/10/19 8:02 PM, Josh Triplett wrote:
> On April 10, 2019 4:24:18 PM PDT, Kees Cook <keescook@chromium.org> wrote:
>> On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett <josh@joshtriplett.org>
>> wrote:
>>>
>>> On April 10, 2019 3:58:55 PM PDT, Kees Cook <keescook@chromium.org>
>> wrote:
>>>> On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya <okaya@kernel.org> wrote:
>>>>>
>>>>> We can't seem to have a kernel with CONFIG_EXPERT set but
>>>>> CONFIG_DEBUG_KERNEL unset these days.
>>>>>
>>>>> While some of the features under the CONFIG_EXPERT require
>>>>> CONFIG_DEBUG_KERNEL, it doesn't apply for all features.
>>>>>
>>>>> It looks like CONFIG_KALLSYMS_ALL is the only feature that
>>>>> requires CONFIG_DEBUG_KERNEL.
>>>>>
>>>>> Select CONFIG_EXPERT when CONFIG_DEBUG is chosen but you can
>>>>
>>>> Typo: CONFIG_DEBUG_KERNEL
>>>>
>>>>> still choose CONFIG_EXPERT without CONFIG_DEBUG.
>>>>
>>>> same.
>>>>
>>>>>
>>>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>>>
>>>> But with those fixed, looks good to me. Adding Josh (and others) to
>> CC
>>>> since he originally added the linkage to EXPERT in commit
>>>> f505c553dbe2.
>>>
>>> CONFIG_DEBUG_KERNEL shouldn't affect code generation in any way; it
>> should only make more options appear in kconfig. I originally added
>> this to ensure that features you might want to *disable* aren't hidden,
>> as part of the tinification effort.
>>>
>>> What specific problem does having CONFIG_DEBUG_KERNEL enabled cause
>> for you? I'd still prefer to have a single switch for "don't hide
>> things I might want to disable", rather than several.
>>
>> See earlier in the thread: code generation depends on
>> CONFIG_DEBUG_KERNEL now unfortunately.
>
> Then let's fix *that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this.
>
checkpatch is not an enforcer. It takes maintainers to do that.
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-11 3:13 ` Sinan Kaya
@ 2019-04-11 22:16 ` Josh Triplett
2019-04-11 22:21 ` Kees Cook
0 siblings, 1 reply; 11+ messages in thread
From: Josh Triplett @ 2019-04-11 22:16 UTC (permalink / raw)
To: Sinan Kaya
Cc: Kees Cook, LKML, Masahiro Yamada, Andrew Morton,
Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On Wed, Apr 10, 2019 at 11:13:52PM -0400, Sinan Kaya wrote:
> On 4/10/2019 11:02 PM, Josh Triplett wrote:
> > Then let's fix*that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this.
>
> I think we have to do both. We need to go after the users as well as
> solve the immediate problem per this patch.
>
> As Mathieu identified, CONFIG_DEBUG_KERNEL is being used all over the
> place and getting subsystem owners to remove let alone add a check
> to checkpatch is just going to take time.
>
> Please let us know if you are OK with this plan.
I'm not OK with this plan. Turning on EXPERT should make the options
under DEBUG_KERNEL visible; it's a bug that DEBUG_KERNEL affects code
generation as well.
Proposed alternative plan: let's add a new symbol, something like
DEBUG_MISC ("Miscellaneous debug code that should be under a more
specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
"default DEBUG_KERNEL" but allow itself to be turned off, and then
mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
"#ifdef CONFIG_DEBUG_MISC".
Does that sound like an appropriately rapid solution for this bug?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-11 22:16 ` Josh Triplett
@ 2019-04-11 22:21 ` Kees Cook
2019-04-11 22:27 ` Sinan Kaya
0 siblings, 1 reply; 11+ messages in thread
From: Kees Cook @ 2019-04-11 22:21 UTC (permalink / raw)
To: Josh Triplett
Cc: Sinan Kaya, Kees Cook, LKML, Masahiro Yamada, Andrew Morton,
Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On Thu, Apr 11, 2019 at 3:16 PM Josh Triplett <josh@joshtriplett.org> wrote:
>
> On Wed, Apr 10, 2019 at 11:13:52PM -0400, Sinan Kaya wrote:
> > On 4/10/2019 11:02 PM, Josh Triplett wrote:
> > > Then let's fix*that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this.
> >
> > I think we have to do both. We need to go after the users as well as
> > solve the immediate problem per this patch.
> >
> > As Mathieu identified, CONFIG_DEBUG_KERNEL is being used all over the
> > place and getting subsystem owners to remove let alone add a check
> > to checkpatch is just going to take time.
> >
> > Please let us know if you are OK with this plan.
>
> I'm not OK with this plan. Turning on EXPERT should make the options
> under DEBUG_KERNEL visible; it's a bug that DEBUG_KERNEL affects code
> generation as well.
>
> Proposed alternative plan: let's add a new symbol, something like
> DEBUG_MISC ("Miscellaneous debug code that should be under a more
> specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
> "default DEBUG_KERNEL" but allow itself to be turned off, and then
> mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
> "#ifdef CONFIG_DEBUG_MISC".
>
> Does that sound like an appropriately rapid solution for this bug?
Sure, that sounds fine to me. Sinan can you take care of that for v4?
--
Kees Cook
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-11 22:21 ` Kees Cook
@ 2019-04-11 22:27 ` Sinan Kaya
2019-04-11 22:34 ` Josh Triplett
0 siblings, 1 reply; 11+ messages in thread
From: Sinan Kaya @ 2019-04-11 22:27 UTC (permalink / raw)
To: Kees Cook, Josh Triplett
Cc: LKML, Masahiro Yamada, Andrew Morton, Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On 4/11/2019 6:21 PM, Kees Cook wrote:
>> Proposed alternative plan: let's add a new symbol, something like
>> DEBUG_MISC ("Miscellaneous debug code that should be under a more
>> specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
>> "default DEBUG_KERNEL" but allow itself to be turned off, and then
>> mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
>> "#ifdef CONFIG_DEBUG_MISC".
>>
>> Does that sound like an appropriately rapid solution for this bug?
> Sure, that sounds fine to me. Sinan can you take care of that for v4?
Sure, let me work on this.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
2019-04-11 22:27 ` Sinan Kaya
@ 2019-04-11 22:34 ` Josh Triplett
0 siblings, 0 replies; 11+ messages in thread
From: Josh Triplett @ 2019-04-11 22:34 UTC (permalink / raw)
To: Sinan Kaya
Cc: Kees Cook, LKML, Masahiro Yamada, Andrew Morton,
Peter Zijlstra (Intel),
Johannes Weiner, Nicholas Piggin, Mathieu Desnoyers,
Vasily Gorbik, Adrian Reber, Richard Guy Briggs, Petr Mladek,
Andy Shevchenko, Matthew Wilcox, Joe Lawrence, Randy Dunlap,
Mikulas Patocka, Robin Murphy, Tetsuo Handa, Changbin Du,
Frederic Weisbecker, Sam Ravnborg, Ingo Molnar
On Thu, Apr 11, 2019 at 06:27:04PM -0400, Sinan Kaya wrote:
> On 4/11/2019 6:21 PM, Kees Cook wrote:
> > > Proposed alternative plan: let's add a new symbol, something like
> > > DEBUG_MISC ("Miscellaneous debug code that should be under a more
> > > specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
> > > "default DEBUG_KERNEL" but allow itself to be turned off, and then
> > > mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
> > > "#ifdef CONFIG_DEBUG_MISC".
> > >
> > > Does that sound like an appropriately rapid solution for this bug?
> > Sure, that sounds fine to me. Sinan can you take care of that for v4?
>
> Sure, let me work on this.
Thank you both! I really appreciate that.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-04-11 22:34 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 22:42 [PATCH v2] init: Do not select DEBUG_KERNEL by default Sinan Kaya
2019-04-10 22:58 ` Kees Cook
2019-04-10 23:22 ` Josh Triplett
2019-04-10 23:24 ` Kees Cook
2019-04-11 3:02 ` Josh Triplett
2019-04-11 3:13 ` Sinan Kaya
2019-04-11 22:16 ` Josh Triplett
2019-04-11 22:21 ` Kees Cook
2019-04-11 22:27 ` Sinan Kaya
2019-04-11 22:34 ` Josh Triplett
2019-04-11 3:44 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).