From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: mansur@codeaurora.org, Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org,
dikshita@codeaurora.org
Subject: Re: [V3] venus: vdec: decoded picture buffer handling during reconfig sequence
Date: Tue, 28 Sep 2021 15:59:13 +0300 [thread overview]
Message-ID: <cf3158dd-b379-0e03-2bdd-187dc268b0b4@linaro.org> (raw)
In-Reply-To: <4db580aea0ddfc6092fd86b51e67802f@codeaurora.org>
Hi,
>>>
>>> +static DEFINE_IDA(dpb_out_tag_ida);
>>
>> No global static variables please. Make it part of venus_inst structure.
> As per my understanding it is not just static global variable.
> We are defining the ida structure and assign to name when pass as param
> as follows
> struct ida {
> struct idr idr;
> struct ida_bitmap *free_bitmap;
> };
> #define IDA_INIT(name) { .idr = IDR_INIT((name).idr),
> .free_bitmap = NULL, }
> #define DEFINE_IDA(name) struct ida name = IDA_INIT(name)
>
> Any ida related API's expect pointer to this structure.
> If we move the variable then it might be bit difficult use ida_xxx()
> API'same
Add a struct ida dpb_ids in venus_inst or venus_core structures
depending on what you need (ID allocations per session or for all
sessions) and use ida_init(&dpb_ids).
--
--
regards,
Stan
prev parent reply other threads:[~2021-09-28 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 11:08 [V3] venus: vdec: decoded picture buffer handling during reconfig sequence Mansur Alisha Shaik
2021-09-21 13:47 ` Stanimir Varbanov
2021-09-27 5:24 ` mansur
2021-09-28 4:25 ` mansur
2021-09-28 12:59 ` Stanimir Varbanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf3158dd-b379-0e03-2bdd-187dc268b0b4@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mansur@codeaurora.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).