From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbdCCLjZ (ORCPT ); Fri, 3 Mar 2017 06:39:25 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37511 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbdCCLjG (ORCPT ); Fri, 3 Mar 2017 06:39:06 -0500 Subject: Re: [PATCH 1/2] nvmem: Add driver for the i.MX IIM To: Sascha Hauer , linux-kernel@vger.kernel.org References: <20170213153149.11710-1-s.hauer@pengutronix.de> <20170213153149.11710-2-s.hauer@pengutronix.de> <568bbe58-0bb5-f7ec-a646-271912a4313a@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, Maxime Ripard , Shawn Guo , Fabio Estevam , kernel@pengutronix.de, Rob Herring , Mark Rutland , Michael Grzeschik From: Srinivas Kandagatla Message-ID: Date: Fri, 3 Mar 2017 09:54:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <568bbe58-0bb5-f7ec-a646-271912a4313a@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/17 09:50, Srinivas Kandagatla wrote: > > > On 13/02/17 15:31, Sascha Hauer wrote: >> From: Michael Grzeschik >> >> This adds a readonly nvmem driver for the i.MX IC Identification Module >> (IIM). The IIM is found on the older i.MX SoCs like the i.MX25, i.MX27, >> i.MX31, i.MX35, i.MX51 and the i.MX53. >> >> The IIM can control up to 8 fuse banks with 256 bit each. Not all of the >> banks are equipped on the different SoCs. The actual number of fuses >> differ from 512 on the i.MX27 and 1152 on the i.MX53. >> >> The fuses are one time writable, but writing is currently not supported >> in the driver. >> >> Signed-off-by: Michael Grzeschik >> Signed-off-by: Sascha Hauer > > >> --- >> drivers/nvmem/Kconfig | 11 ++++ >> drivers/nvmem/Makefile | 2 + >> drivers/nvmem/imx-iim.c | 171 >> ++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 184 insertions(+) >> create mode 100644 drivers/nvmem/imx-iim.c > > Patch looks good to me, Will pick both bindings and this patch in next > cycle for 4.12. Opps sent email too quick.. Can you also make sure that ids are null terminated as reported by kbuild https://www.spinics.net/lists/arm-kernel/msg562543.html in next version. --srini > > thanks, > srini