From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@suse.com>, Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Muchun Song <songmuchun@bytedance.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/7] mm,hugetlb: Drop clearing of flag from prep_new_huge_page
Date: Thu, 15 Apr 2021 14:41:41 +0200 [thread overview]
Message-ID: <cf4a3e6d-f69a-cf0b-dc66-b55ad06a1d1c@redhat.com> (raw)
In-Reply-To: <YHgmgtJRadMB2c5k@dhcp22.suse.cz>
On 15.04.21 13:41, Michal Hocko wrote:
> On Thu 15-04-21 12:35:40, Oscar Salvador wrote:
>> Pages allocated after boot get its private field cleared by means
>> of post_alloc_hook().
>
> You surely meant to say s@boot@page/cma allocator@ here
I think this also includes allocating gigantic pages via
alloc_contig_pages() directly. post_alloc_hook() covers both.
>
>> Pages allocated during boot, that is directly from the memblock allocator,
>> get cleared by paging_init()->..->memmap_init_zone->..->__init_single_page()
>> before any memblock allocation.
>>
>> Based on this ground, let us remove the clearing of the flag from
>> prep_new_huge_page() as it is not needed.
>
> I would also mention that this is a leftover from 6c0371490140
> ("hugetlb: convert PageHugeFreed to HPageFreed flag"). Previously the
> explicit clearing was necessary because compound allocations do not get
> this initialization (see prep_compound_page).
>
>> Signed-off-by: Oscar Salvador <osalvador@suse.de>
>
> with that
> Acked-by: Michal Hocko <mhocko@suse.com>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-04-15 12:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:35 [PATCH v8 0/7] Make alloc_contig_range handle Hugetlb pages Oscar Salvador
2021-04-15 10:35 ` [PATCH v8 1/7] mm,page_alloc: Bail out earlier on -ENOMEM in alloc_contig_migrate_range Oscar Salvador
2021-04-15 10:35 ` [PATCH v8 2/7] mm,compaction: Let isolate_migratepages_{range,block} return error codes Oscar Salvador
2021-04-15 12:42 ` David Hildenbrand
2021-04-15 10:35 ` [PATCH v8 3/7] mm,hugetlb: Drop clearing of flag from prep_new_huge_page Oscar Salvador
2021-04-15 11:41 ` Michal Hocko
2021-04-15 12:41 ` David Hildenbrand [this message]
2021-04-15 18:50 ` Mike Kravetz
2021-04-15 10:35 ` [PATCH v8 4/7] mm,hugetlb: Split prep_new_huge_page functionality Oscar Salvador
2021-04-15 12:42 ` David Hildenbrand
2021-04-15 10:35 ` [PATCH v8 5/7] mm: Make alloc_contig_range handle free hugetlb pages Oscar Salvador
2021-04-15 12:45 ` David Hildenbrand
2021-04-15 18:54 ` Mike Kravetz
2021-04-15 10:35 ` [PATCH v8 6/7] mm: Make alloc_contig_range handle in-use " Oscar Salvador
2021-04-15 10:35 ` [PATCH v8 7/7] mm,page_alloc: Drop unnecessary checks from pfn_range_valid_contig Oscar Salvador
2021-04-15 11:42 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf4a3e6d-f69a-cf0b-dc66-b55ad06a1d1c@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).