From: Yibin Gong <yibin.gong@freescale.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: "Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator
Date: Tue, 27 May 2014 03:05:35 +0000 [thread overview]
Message-ID: <cf4da38b716044d598a0e3b77f403f39@BLUPR03MB036.namprd03.prod.outlook.com> (raw)
In-Reply-To: <1401098173.12646.1.camel@phoenix>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1419 bytes --]
Tested-by: Robin Gong <b38343@freescale.com>
Acked-by: Robin Gong <b38343@freescale.com>
-----Original Message-----
From: Axel Lin [mailto:axel.lin@ingics.com]
Sent: Monday, May 26, 2014 5:56 PM
To: Mark Brown
Cc: Gong Yibin-B38343; Estevam Fabio-R49496; Liam Girdwood; linux-kernel@vger.kernel.org
Subject: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator
Current code has .enable_reg and .enable_mask settings, but the implementation for corresponding callbacks are missing. Fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Robin,
Can you review and test this patch?
Thanks,
Axel
drivers/regulator/pfuze100-regulator.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 67e678c..b6b4529 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -125,6 +125,9 @@ static struct regulator_ops pfuze100_ldo_regulator_ops = { };
static struct regulator_ops pfuze100_fixed_regulator_ops = {
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+ .is_enabled = regulator_is_enabled_regmap,
.list_voltage = regulator_list_voltage_linear, };
--
1.8.3.2
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2014-05-27 3:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 9:56 [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator Axel Lin
2014-05-27 3:05 ` Yibin Gong [this message]
2014-05-27 11:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf4da38b716044d598a0e3b77f403f39@BLUPR03MB036.namprd03.prod.outlook.com \
--to=yibin.gong@freescale.com \
--cc=Fabio.Estevam@freescale.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).