From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7EDECAAD4 for ; Fri, 26 Aug 2022 14:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343673AbiHZOGG (ORCPT ); Fri, 26 Aug 2022 10:06:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242728AbiHZOGB (ORCPT ); Fri, 26 Aug 2022 10:06:01 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55D84C0E59 for ; Fri, 26 Aug 2022 07:05:59 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id z16so1930963wrh.10 for ; Fri, 26 Aug 2022 07:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Z+0yDajJ0wMjpgyqOUnKw47mL+zdc8UQAtbyK28TADE=; b=1TrEMsMjrNGXQg3zlIfMbp6DcGA/mnvnYEcXOVNWIZtxGMMtIIDBXFAdTbQdg1JhiZ NOUGwIig0tV7ocKG7N6MfxSRKKhCjxzyzNULveaen25A473Kz6VG6VewMXb6F9ODrHl3 prvKMEYieaPC+isGsSBb5ZIGpmk1EXoIf7Xw/CMMowCQsPdIVOPsUbH3NE90Rjt6Vgsb wFetqy6U4nj5bS5DNnxsjUfxh4KXHMP2z9YMVBFv7o0B8WdX4pq+IybwfAv9Uh3nXWjK EtbG3Zxi2O/zO0WdLbyauOW08/7V+J6sJJ+2QI6d9IPSydep7VVX/UsSRlXBZFPlcItP /Dkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Z+0yDajJ0wMjpgyqOUnKw47mL+zdc8UQAtbyK28TADE=; b=GzLWfh8eXYPppwZ1j41n62+EJQOv63ckGo0KtQMDtwFVilZJzOZnIBjvCN4MrVIpP+ i0BDQ6DbGVLNKcMk5iZB8qnShCMdBs1i12LoTS0BHO926+3rNzhKhsTbf7PdiUfGR6kJ F9MRLWsF4gX/yutIyWSf72w0G0lSWdc+Hblxt5L/avY+MuimbyTDtfgZsOfAifmsPa76 lWVmtxnHPK5o5G7WTWSxhPj0021Xa/p81GOGZnPaZK59CeMjlCdzKrebrKPDkvza/o8C PyMUK9+Zq+mrrzpwG6FKzFOAOnaXpgb6lW7QL7JYWPPu3z207//Acu2VEwcBiEl8V9gb 8Fig== X-Gm-Message-State: ACgBeo0jr9wEjuZ7qvJ2KHXsUoP1psMUHnB+/vXb8nwtON8MpnVQoHXi VU+3gttC8CXMmWDgMyNs8R2t2g== X-Google-Smtp-Source: AA6agR5LuyIlDMydRhgyzTFzClAGY8aeGYDhoH5FtmW4fur5TkLAwiWQlSHq4jMGUpVO741aer/a0w== X-Received: by 2002:a5d:5305:0:b0:225:453a:be9b with SMTP id e5-20020a5d5305000000b00225453abe9bmr5058563wrv.516.1661522757838; Fri, 26 Aug 2022 07:05:57 -0700 (PDT) Received: from [192.168.0.20] (210.145.15.109.rev.sfr.net. [109.15.145.210]) by smtp.gmail.com with ESMTPSA id j2-20020adff542000000b0021e51c039c5sm1967727wrp.80.2022.08.26.07.05.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 07:05:57 -0700 (PDT) Message-ID: Date: Fri, 26 Aug 2022 16:05:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 3/4] thermal: mediatek: control buffer enablement tweaks Content-Language: en-US To: AngeloGioacchino Del Regno , matthias.bgg@gmail.com Cc: rafael@kernel.org, fparent@baylibre.com, amitk@kernel.org, daniel.lezcano@linaro.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org, robh+dt@kernel.org, rui.zhang@intel.com, Markus Schneider-Pargmann References: <20220720181854.547881-1-aouledameur@baylibre.com> <20220720181854.547881-4-aouledameur@baylibre.com> From: Amjad Ouled-Ameur In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Angelo, On 7/21/22 10:11, AngeloGioacchino Del Regno wrote: > Il 20/07/22 20:18, Amjad Ouled-Ameur ha scritto: >> From: Markus Schneider-Pargmann >> >> Add logic in order to be able to turn on the control buffer on MT8365. >> This change now allows to have control buffer support for >> MTK_THERMAL_V1, >> and it allows to define the register offset, and mask used to enable it. >> >> Signed-off-by: Markus Schneider-Pargmann >> Signed-off-by: Fabien Parent >> Reviewed-by: Amjad Ouled-Ameur >> Tested-by: Amjad Ouled-Ameur >> --- >>   drivers/thermal/mtk_thermal.c | 23 +++++++++++++++++------ >>   1 file changed, 17 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/thermal/mtk_thermal.c >> b/drivers/thermal/mtk_thermal.c >> index 216eb0d61c5b..1dc276f8c4f1 100644 >> --- a/drivers/thermal/mtk_thermal.c >> +++ b/drivers/thermal/mtk_thermal.c >> @@ -283,6 +283,9 @@ struct mtk_thermal_data { >>       bool need_switch_bank; >>       struct thermal_bank_cfg bank_data[MAX_NUM_ZONES]; >>       enum mtk_thermal_version version; >> +    u32 apmixed_buffer_ctl_reg; >> +    u32 apmixed_buffer_ctl_mask; >> +    u32 apmixed_buffer_ctl_set; >>   }; >>     struct mtk_thermal { >> @@ -578,6 +581,9 @@ static const struct mtk_thermal_data >> mt7622_thermal_data = { >>       .adcpnp = mt7622_adcpnp, >>       .sensor_mux_values = mt7622_mux_values, >>       .version = MTK_THERMAL_V2, >> +    .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1, >> +    .apmixed_buffer_ctl_mask = ~0x37, > > This is effectively GENMASK(31, 6) | BIT(3) :-) > >> +    .apmixed_buffer_ctl_set = 0x1, > > ...and this is BIT(0) > Thank you for the catch, will update them appropriately. >>   }; > >>   /* >> @@ -1031,14 +1037,18 @@ static const struct of_device_id >> mtk_thermal_of_match[] = { >>   }; >>   MODULE_DEVICE_TABLE(of, mtk_thermal_of_match); >>   -static void mtk_thermal_turn_on_buffer(void __iomem *apmixed_base) >> +static void mtk_thermal_turn_on_buffer(struct mtk_thermal *mt, >> +                       void __iomem *apmixed_base) >>   { >>       int tmp; > > Since you're practically restructuring this function, please fix this > wrong > variable type, as this should be a u32. > Sure agreed. Thank you Angelo for the review. Regards, Amjad > Regards, > Angelo