From: Sinan Kaya <okaya@codeaurora.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
sulrich@codeaurora.org, Netdev <netdev@vger.kernel.org>,
Timur Tabi <timur@codeaurora.org>,
LKML <linux-kernel@vger.kernel.org>,
intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-wired-lan] [PATCH v6 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 14:27:28 -0400 [thread overview]
Message-ID: <cf6191c0-07cc-226b-d780-f488a0d7c779@codeaurora.org> (raw)
In-Reply-To: <CAKgT0UfCm4SJAhwyHKrHZnoJWKpp6-DWWVUb-YKgA2NTQhx=RA@mail.gmail.com>
On 3/23/2018 2:25 PM, Alexander Duyck wrote:
>> + /* We need this if more than one processor can write to our tail
>> + * at a time, it synchronizes IO on IA64/Altix systems
>> + */
>> + mmiowb();
>> }
> The mmiowb shouldn't be needed for Rx. Only one CPU will be running
> NAPI for the queue and we will synchronize this with a full writel
> anyway when we re-enable the interrupts.
>
OK. I can fix this on the next version. I did a blanket search and replace for
my writel_relaxed() changes as I don't know the code well enough.
Please point me to the redundant ones.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-03-23 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1521829277-9398-1-git-send-email-okaya@codeaurora.org>
2018-03-23 18:21 ` [PATCH v6 1/7] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 18:30 ` [Intel-wired-lan] " Alexander Duyck
2018-03-23 18:21 ` [PATCH v6 2/7] ixgbe: eliminate " Sinan Kaya
2018-03-23 18:21 ` [PATCH v6 3/7] igbvf: " Sinan Kaya
2018-03-23 18:21 ` [PATCH v6 4/7] igb: " Sinan Kaya
2018-03-23 18:21 ` [PATCH v6 5/7] fm10k: Eliminate " Sinan Kaya
2018-03-23 18:21 ` [PATCH v6 6/7] ixgbevf: keep writel() closer to wmb() Sinan Kaya
2018-03-23 18:21 ` [PATCH v6 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 18:25 ` [Intel-wired-lan] " Alexander Duyck
2018-03-23 18:27 ` Sinan Kaya [this message]
2018-03-23 18:31 ` Alexander Duyck
2018-03-23 18:45 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf6191c0-07cc-226b-d780-f488a0d7c779@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=alexander.duyck@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).