From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Akira Yokosawa <akiyks@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Andrea Parri <parri.andrea@gmail.com>,
Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Boqun Feng <boqun.feng@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Jade Alglave <j.alglave@ucl.ac.uk>,
Luc Maranget <luc.maranget@inria.fr>,
Daniel Lustig <dlustig@nvidia.com>,
Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH] tools/memory-model: Use "grep -E" instead of "egrep"
Date: Mon, 21 Nov 2022 11:02:07 +0800 [thread overview]
Message-ID: <cf646450-c908-519b-f07a-b51c3946ad7f@loongson.cn> (raw)
In-Reply-To: <d0d2ea9e-9345-f462-b15b-edf31024f7d5@gmail.com>
On 11/20/2022 07:19 PM, Akira Yokosawa wrote:
> On Sat, 19 Nov 2022 10:13:18 +0800, Tiezhu Yang wrote:
>> The latest version of grep claims the egrep is now obsolete so the build
>> now contains warnings that look like:
>> egrep: warning: egrep is obsolescent; using grep -E
>> fix this up by moving the related file to use "grep -E" instead.
>>
>> sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/memory-model`
>>
>> Here are the steps to install the latest grep:
>>
>> wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
>> tar xf grep-3.8.tar.gz
>> cd grep-3.8 && ./configure && make
>> sudo make install
>> export PATH=/usr/local/bin:$PATH
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>> tools/memory-model/scripts/checkghlitmus.sh | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/memory-model/scripts/checkghlitmus.sh b/tools/memory-model/scripts/checkghlitmus.sh
>> index 6589fbb..f72816a 100755
>> --- a/tools/memory-model/scripts/checkghlitmus.sh
>> +++ b/tools/memory-model/scripts/checkghlitmus.sh
>> @@ -35,13 +35,13 @@ fi
>> # Create a list of the C-language litmus tests previously run.
>> ( cd $LKMM_DESTDIR; find litmus -name '*.litmus.out' -print ) |
>> sed -e 's/\.out$//' |
>> - xargs -r egrep -l '^ \* Result: (Never|Sometimes|Always|DEADLOCK)' |
>> + xargs -r grep -E -l '^ \* Result: (Never|Sometimes|Always|DEADLOCK)' |
>> xargs -r grep -L "^P${LKMM_PROCS}"> $T/list-C-already
>>
>> # Create a list of C-language litmus tests with "Result:" commands and
>> # no more than the specified number of processes.
>> find litmus -name '*.litmus' -exec grep -l -m 1 "^C " {} \; > $T/list-C
>> -xargs < $T/list-C -r egrep -l '^ \* Result: (Never|Sometimes|Always|DEADLOCK)' > $T/list-C-result
>> +xargs < $T/list-C -r grep -E -l '^ \* Result: (Never|Sometimes|Always|DEADLOCK)' > $T/list-C-result
>> xargs < $T/list-C-result -r grep -L "^P${LKMM_PROCS}" > $T/list-C-result-short
>>
>> # Form list of tests without corresponding .litmus.out files
>
> Looks good to me.
>
> Reviewed-by: Akira Yokosawa <akiyks@gmail.com>
>
> Paul, JFYI, this patch doesn't apply cleanly on -rcu dev due to
> a couple of changes in the lkmm-dev.2022.10.18c branch.
>
> Thanks, Akira
>
Hi Akira,
Thanks for your review, sorry for that, let me rebase on
linux-rcu.git dev and send v2 later.
Thanks,
Tiezhu
prev parent reply other threads:[~2022-11-21 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 2:13 [PATCH] tools/memory-model: Use "grep -E" instead of "egrep" Tiezhu Yang
2022-11-20 11:19 ` Akira Yokosawa
2022-11-21 3:02 ` Tiezhu Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf646450-c908-519b-f07a-b51c3946ad7f@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=akiyks@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).