From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Hao Lee <haolee.swjtu@gmail.com>, akpm@linux-foundation.org
Cc: mgorman@techsingularity.net, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix comments related to node reclaim
Date: Tue, 26 Nov 2019 15:13:22 +0530 [thread overview]
Message-ID: <cf85d546-3b6c-e172-3624-0e40e0f7699c@arm.com> (raw)
In-Reply-To: <20191125142018.GA21373@haolee.github.io>
On 11/25/2019 07:50 PM, Hao Lee wrote:
> As zone reclaim has been replaced by node reclaim, this patch fixes related
> comments.
>
> Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
> ---
> include/linux/mmzone.h | 2 +-
> include/uapi/linux/capability.h | 2 +-
> include/uapi/linux/sysctl.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 9e47289a4511..7e3208f4f5bc 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -747,7 +747,7 @@ typedef struct pglist_data {
>
> #ifdef CONFIG_NUMA
> /*
> - * zone reclaim becomes active if more unmapped pages exist.
> + * node reclaim becomes active if more unmapped pages exist.
> */
> unsigned long min_unmapped_pages;
> unsigned long min_slab_pages;
> diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
> index 240fdb9a60f6..dd6772f16eec 100644
> --- a/include/uapi/linux/capability.h
> +++ b/include/uapi/linux/capability.h
> @@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
> /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
> arbitrary SCSI commands */
> /* Allow setting encryption key on loopback filesystem */
> -/* Allow setting zone reclaim policy */
> +/* Allow setting node reclaim policy */
Does this point to the capability for accessing vm.zone_reclaim_mode = 0
sysctl knob ? In that case we should not be changing the name here as the
interface still retains the original name 'zone_reclaim_mode'.
>
> #define CAP_SYS_ADMIN 21
>
> diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
> index 87aa2a6d9125..27c1ed2822e6 100644
> --- a/include/uapi/linux/sysctl.h
> +++ b/include/uapi/linux/sysctl.h
> @@ -195,7 +195,7 @@ enum
> VM_MIN_UNMAPPED=32, /* Set min percent of unmapped pages */
> VM_PANIC_ON_OOM=33, /* panic at out-of-memory */
> VM_VDSO_ENABLED=34, /* map VDSO into new processes? */
> - VM_MIN_SLAB=35, /* Percent pages ignored by zone reclaim */
> + VM_MIN_SLAB=35, /* Percent pages ignored by node reclaim */
> };
>
>
>
next prev parent reply other threads:[~2019-11-26 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 14:20 [PATCH] mm: fix comments related to node reclaim Hao Lee
2019-11-26 9:43 ` Anshuman Khandual [this message]
2019-11-26 14:09 ` Hao Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf85d546-3b6c-e172-3624-0e40e0f7699c@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=haolee.swjtu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).