From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9555EC3279B for ; Fri, 6 Jul 2018 10:03:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F6BF24003 for ; Fri, 6 Jul 2018 10:03:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZMRfTFVI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F6BF24003 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753615AbeGFKDK (ORCPT ); Fri, 6 Jul 2018 06:03:10 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:53804 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbeGFKDH (ORCPT ); Fri, 6 Jul 2018 06:03:07 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id w66A2gDq125003; Fri, 6 Jul 2018 05:02:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1530871362; bh=IBeuIYaOQyZaPIY/EY7u6tLtSbjMhl5xTYxTfEZFhzo=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=ZMRfTFVI+D999v7g3UArDU9INiwxQfY/Ybglur7TnHsQ/nG2qGp6tqOw0kMo6NprQ C8hxmlMfjR/8eS7G4K1Sy3W2ytmFW6mSVjWRSoyxPIOYNZ5JoAtQRG9KQXE9FXM3Q2 bw6L/VvaaqZjC7EiSx983xaeaFGEs/2mbCz/31Ts= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w66A2f7L015980; Fri, 6 Jul 2018 05:02:41 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 6 Jul 2018 05:02:41 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 6 Jul 2018 05:02:41 -0500 Received: from [172.24.190.215] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w66A2bWx001208; Fri, 6 Jul 2018 05:02:38 -0500 Subject: Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset To: Tony Lindgren CC: , , , , , , , , , References: <20180705142319.19583-1-faiz_abbas@ti.com> <20180705142319.19583-5-faiz_abbas@ti.com> <20180705154758.GA112168@atomide.com> From: Faiz Abbas Message-ID: Date: Fri, 6 Jul 2018 15:34:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180705154758.GA112168@atomide.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote: > * Faiz Abbas [180705 14:24]: >> +static int sysc_reset(struct sysc *ddata) >> +{ >> + int offset = ddata->offsets[SYSC_SYSCONFIG]; >> + int val = sysc_read(ddata, offset); > > Can you please just warn and return early for now if no > syss_mask is specified? Otherwise we'll have mysterious > errors if somebody leaves out "ti,hwmods" for module types > we do not yet support reset for. RESET write to sysconfig can still happen even if there's no syss_mask right? Not all modules need to poll on reset status. Thanks, Faiz