From: Hans Verkuil <hverkuil@xs4all.nl>
To: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
Cc: Corentin Labbe <clabbe@baylibre.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging: media: zoran: Removed braces for single statement block
Date: Wed, 24 Aug 2022 11:48:54 +0200 [thread overview]
Message-ID: <cf992081-eb0c-009d-f283-1602b74a9293@xs4all.nl> (raw)
In-Reply-To: <20220721150055.52096-1-abhijeet.srivastava2308@gmail.com>
Hi Abhijeet,
Thank you for the zoran patches, unfortunately these are a duplicate of
https://patchwork.linuxtv.org/project/linux-media/patch/20220810115445.2302477-2-hverkuil-cisco@xs4all.nl/
I wish I'd noticed your patches earlier, it would have saved me some work :-(
I'm marking your patches Obsoleted in patchwork.
Regards,
Hans
On 21/07/2022 17:00, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
> ---
> drivers/staging/media/zoran/zoran_card.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c
> index 26f978a1cc72..0c138d47d0c3 100644
> --- a/drivers/staging/media/zoran/zoran_card.c
> +++ b/drivers/staging/media/zoran/zoran_card.c
> @@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
> zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
> BUZ_NUM_STAT_COM * sizeof(u32),
> &zr->p_sc, GFP_KERNEL);
> - if (!zr->stat_com) {
> + if (!zr->stat_com)
> return -ENOMEM;
> - }
> +
> for (j = 0; j < BUZ_NUM_STAT_COM; j++)
> zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to zr36057 */
>
prev parent reply other threads:[~2022-08-24 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 15:00 [PATCH] media: staging: media: zoran: Removed braces for single statement block Abhijeet Srivastava
2022-07-22 4:54 ` Philipp Hortmann
2022-08-24 9:48 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf992081-eb0c-009d-f283-1602b74a9293@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=abhijeet.srivastava2308@gmail.com \
--cc=clabbe@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).