From: Randy Dunlap <rdunlap@infradead.org>
To: Gavin Shan <gshan@redhat.com>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
drjones@redhat.com, shan.gavin@gmail.com
Subject: Re: [PATCH] Documentation, dt, numa: Add note to empty NUMA node
Date: Wed, 23 Jun 2021 22:37:40 -0700 [thread overview]
Message-ID: <cfba8d64-810d-675b-8727-66c84106883c@infradead.org> (raw)
In-Reply-To: <435d4707-3871-26fe-e0e4-df93931ba49d@redhat.com>
On 6/23/21 9:58 PM, Gavin Shan wrote:
> On 6/24/21 12:14 PM, Randy Dunlap wrote:
>> On 6/23/21 8:37 PM, Gavin Shan wrote:
>>> The empty NUMA nodes, where no memory resides in, are allowed. For
>>> these empty NUMA nodes, the 'len' of 'reg' property is zero. These
>>> empty NUMA node IDs are still valid and parsed. I finds difficulty
>>> to get where it's properly documented.
>>>
>>> So lets add note to empty NUMA nodes in the NUMA binding doc.
>>>
>>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>>> ---
>>> Documentation/devicetree/bindings/numa.txt | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt
>>> index 21b35053ca5a..c564705c0eac 100644
>>> --- a/Documentation/devicetree/bindings/numa.txt
>>> +++ b/Documentation/devicetree/bindings/numa.txt
>>> @@ -109,6 +109,10 @@ Example:
>>> Dual socket system consists of 2 boards connected through ccn bus and
>>> each board having one socket/soc of 8 cpus, memory and pci bus.
>>> +Note that the empty NUMA nodes, which no memory resides in, are allowed
>>
>> Missing period at end of the sentence above.
>>
>
> Oh, Yes. Thanks, Randy. I will replace "resides in" with "resides in period"
> in v2.
Cute. Would it help if I replaced "period" with Missing "full stop" or '.' at the end
of the sentence?
>>> +Their NUMA node IDs are still valid so that memory can be added into these
>>> +NUMA nodes through hotplug afterwards.
>>> +
>>> memory@c00000 {
>>> device_type = "memory";
>>> reg = <0x0 0xc00000 0x0 0x80000000>;
>
> By the way, I have one more question to check with you if I can. I'm not sure
> if dummy and invalid 'unit-address' is allowed in the empty memory node name,
> which follows the format "memory@unit-address'.
>
> (1) The 'unit-address' is same thing as to 'base address' for memory node,
> as specified in device-tree specification. I'm not sure if 'base address'
> can be dummy and invalid one since empty memory node doesn't have memory
> at all.
>
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#node-names
>
> (2) I don't find the 'unit-address' is used in linux, but I'm not sure other
> software component like firmware uses it or not.
I have no idea about that.
next prev parent reply other threads:[~2021-06-24 5:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 3:37 [PATCH] Documentation, dt, numa: Add note to empty NUMA node Gavin Shan
2021-06-24 2:14 ` Randy Dunlap
2021-06-24 4:58 ` Gavin Shan
2021-06-24 5:37 ` Randy Dunlap [this message]
2021-06-24 7:44 ` Gavin Shan
2021-06-25 2:10 ` Gavin Shan
2021-09-06 4:14 Gavin Shan
2021-09-21 19:44 ` Rob Herring
2021-09-22 11:05 ` Ard Biesheuvel
2021-09-23 6:32 ` Gavin Shan
2021-09-23 15:17 ` Rob Herring
2021-09-27 1:16 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfba8d64-810d-675b-8727-66c84106883c@infradead.org \
--to=rdunlap@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=drjones@redhat.com \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).