From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932588AbcHVQ5U (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 Aug 2016 12:57:20 -0400
Received: from mout.web.de ([212.227.15.3]:51235 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754256AbcHVQ5Q (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Aug 2016 12:57:16 -0400
Subject: Re: [PATCH 3/4] KVM-S390: Less function calls in
 kvm_s390_import_bp_data() after error detection
To: Cornelia Huck <cornelia.huck@de.ibm.com>
References: <82b84c9c-38a4-4d17-910f-312668dbae01@users.sourceforge.net>
 <47f88a11-b949-28ed-5589-925888a37574@users.sourceforge.net>
 <20160822150048.309a3e10.cornelia.huck@de.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
        =?UTF-8?Q?Christian_Borntr=c3=a4ger?= <borntraeger@de.ibm.com>,
        David Hildenbrand <dahi@linux.vnet.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <cff92477-f426-a4c7-fffb-f8bbc378afe7@users.sourceforge.net>
Date: Mon, 22 Aug 2016 18:56:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <20160822150048.309a3e10.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:bL5nUzezfh8Ix2/H7uwYtBXwKBvXvRGg0EM/VxLWdBudn4e/b1I
 BbAR6DYcfsgjYpVI/ARaHDEh6U41yIiGT7BlQv91/XF58cfN0yO6EOKvW2n+isb47rqXTLh
 77poIXWrBCI9DM5S7tMYYQeXx0sQ+Rdk9OkcwPEJn/Ttwzmfpzy8VLW7sfd5ZPKK1uwVQSS
 mG2TDNxfW3Kqfo4y2WLXg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:LLhp28wtQyY=:ii5o4x/9mIFxIAdBEUtE6m
 8uTSE6Zo5luuzyGHx5GqBugCRXhVM/nkJNtmj9RcPB0NfPuDTFbYHcGGTJc2tz11kug1fomNa
 Z1nmhWwAwP77Vy0uy3S9CSGVrxBA/08t6psIm1qknuq84IrNP8TKm7Ao9/qsDF5yXt08z5g1Z
 mg+TxePh7rTkYlxhcaEpGqsnD4oNd/Bh8xvDW883bzk0fy747+vRwip+98MJ/70c3zwRO3qDH
 ZUtdqCaflAno+B9Hman1cfavdrmxRnU6sOnDpNTIiYaRN20v3rXwL2Un+86c9SpCmAx0vrTuw
 RV3J4E3y9Jw2rfrZWK//5rRnuC6pldFuOZEu7sStQLOd5kYyP8QYTUamHGA6yYP3USdKj/DCR
 8mZcdfPtRsBF3cqfEqYBi3EMbBBahj5PzIkuB1589VX71Ti7f/hpJR65SNMlFo6RkaunYY6VU
 uh6Kt3AnuaVK8NEvwSf+6r7hvkNbJMjmhCVWmGH9yPpfcoNd1frTn0ecsoJZ0jPJsVIBNmeYb
 di3he47dQukVacwqWtfe4IAxMr6w2TaY2zoT1yK+pOmY1Kh3VGq7mF3eQdD8/u7pypDNPEsc9
 e+H/XpgSr3ZHqcMhF1hcdr+fehqOWacqfkoukZfZD+gv3G+Ebtn0FpuKylet7T1ONGRT/O7yV
 I0YokIg2KM4ezXqBEN18Rk3rRpB2Of7DHQIWfNsDomXWt/AFIz7SVfHVqnU7BLmDRe7EGuQY5
 ICOwMLQED3NNYDJoEDeJ0QyT537D4TSOboyLul/NWGlMCjb7pULdBvxj9X9LD9fyZBYZiWOz5
 1epvayZ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -273,10 +273,12 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu,
>>  	vcpu->arch.guestdbg.nr_hw_wp = nr_wp;
>>  	vcpu->arch.guestdbg.hw_wp_info = wp_info;
>>  	return 0;
>> -error:
>> -	kfree(bp_data);
>> -	kfree(wp_info);
>> +free_bp_info:
>>  	kfree(bp_info);
>> +free_wp_info:
>> +	kfree(wp_info);
>> +free_bp_data:
>> +	kfree(bp_data);
>>  	return ret;
>>  }
>>
> 
> This replaces a perfectly fine fallthrough

The usage of a single goto label like "error" seems to be convenient.
But how do these habits fit to the current Linux coding style convention?


> with some horrible labels.

Do they explain better which processing steps should be performed
for an efficient exception handling in this function implementation?

Regards,
Markus