linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: peterz@infradead.org, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, andi@firstfloor.org, rostedt@goodmis.org
Subject: [PATCH 0/2] sched: static_key sched_feat race + cleanup
Date: Wed,  2 Jul 2014 15:52:38 +0000 (GMT)	[thread overview]
Message-ID: <cover.1404315388.git.jbaron@akamai.com> (raw)

Hi,

Andi Kleen previously pointed out a get/set race in the sched_feat()
infrastructure. I had previously proposed to address this with a new
static_key set_true/set_false API:

http://www.gossamer-threads.com/lists/linux/kernel/1955879

However, I think its simpler to just add higher level locking as
Ingo previously suggested, and that is how other consumers of the
this interface are already operating. It seems a bit like overkill
to add this new API, just for this one case.

So, this locking change is in patch 2. Patch 1 is a small cleanup, but
no functional change.
 
Thanks,

-Jason

Jason Baron (2):
  sched: remove extra static_key function indirection
  sched: fix static_key race with sched_feat

 kernel/sched/core.c  |  5 +++++
 kernel/sched/sched.h | 12 +-----------
 2 files changed, 6 insertions(+), 11 deletions(-)

-- 
1.8.2.rc2


             reply	other threads:[~2014-07-02 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 15:52 Jason Baron [this message]
2014-07-02 15:52 ` [PATCH 1/2] sched: remove extra static_key function indirection Jason Baron
2014-07-16 19:23   ` [tip:sched/core] sched: Remove extra static_key*() " tip-bot for Jason Baron
2014-07-02 15:52 ` [PATCH 2/2] sched: fix static_key race with sched_feat Jason Baron
2014-07-16 19:23   ` [tip:sched/core] sched: Fix static_key race with sched_feat() tip-bot for Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1404315388.git.jbaron@akamai.com \
    --to=jbaron@akamai.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).