From: Shaohua Li <shli@fb.com>
To: <linux-kernel@vger.kernel.org>
Cc: <axboe@fb.com>, <jmoyer@redhat.com>, <hch@lst.de>, <neilb@suse.de>
Subject: [PATCH 0/5] blk plug fixes
Date: Thu, 30 Apr 2015 10:45:13 -0700 [thread overview]
Message-ID: <cover.1430414609.git.shli@fb.com> (raw)
These are some block plug related patches. The first 3 are independent and can
apply separately.
For the multiple queue case, I only handled !BLK_MQ_F_DEFER_ISSUE case. The
DEFER_ISSUE is really confusing, I'm not sure what's the correct behavior.
BTW, calling blk_mq_merge_queue_io is confusing too to me. The request will be
dispatched immediately or offload to a workqueue to dispatch. In either case,
the request will be dispatched soon. There is a tiny window there are requests
in the queue and requests can be merged. I thought we can delete the code with
plug merge. And if out of order request merge is important, we really should
add a ELEVATOR_INSERT_SORT_MERGE like mechanism. This makes me more confusing
about BLK_MQ_F_DEFER_ISSUE too.
Thanks,
Shaohua
Jeff Moyer (1):
blk-mq: fix plugging in blk_sq_make_request
Shaohua Li (4):
blk: clean up plug
sched: always use blk_schedule_flush_plug in io_schedule_out
blk-mq: do limited block plug for multiple queue case
blk-mq: make plug work for mutiple disks and queues
block/blk-core.c | 34 ++++++++-------
block/blk-mq.c | 120 ++++++++++++++++++++++++++++++++--------------------
block/blk.h | 3 +-
kernel/sched/core.c | 8 +---
4 files changed, 98 insertions(+), 67 deletions(-)
--
1.8.1
next reply other threads:[~2015-04-30 17:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 17:45 Shaohua Li [this message]
2015-04-30 17:45 ` [PATCH 1/5] blk: clean up plug Shaohua Li
2015-05-01 17:11 ` Christoph Hellwig
2015-04-30 17:45 ` [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out Shaohua Li
2015-05-01 17:14 ` Christoph Hellwig
2015-05-01 18:05 ` Shaohua Li
2015-05-01 17:42 ` Jeff Moyer
2015-05-01 18:07 ` Jeff Moyer
2015-05-01 18:28 ` Shaohua Li
2015-05-01 19:37 ` Jeff Moyer
2015-04-30 17:45 ` [PATCH 3/5] blk-mq: fix plugging in blk_sq_make_request Shaohua Li
2015-05-01 17:16 ` Christoph Hellwig
2015-05-01 17:47 ` Jeff Moyer
2015-04-30 17:45 ` [PATCH 4/5] blk-mq: do limited block plug for multiple queue case Shaohua Li
2015-05-01 20:16 ` Jeff Moyer
2015-05-04 19:40 ` Shaohua Li
2015-05-04 19:46 ` Jens Axboe
2015-05-04 20:33 ` Shaohua Li
2015-05-04 20:35 ` Jens Axboe
2015-04-30 17:45 ` [PATCH 5/5] blk-mq: make plug work for mutiple disks and queues Shaohua Li
2015-05-01 20:55 ` Jeff Moyer
2015-05-04 19:44 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1430414609.git.shli@fb.com \
--to=shli@fb.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).