From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932373AbbFTOmW (ORCPT ); Sat, 20 Jun 2015 10:42:22 -0400 Received: from m50-134.163.com ([123.125.50.134]:49132 "EHLO m50-134.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932218AbbFTOmO (ORCPT ); Sat, 20 Jun 2015 10:42:14 -0400 From: Geliang Tang To: Sudip Mukherjee Cc: Geliang Tang , abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: fix sparse warning in comedi_compat32.c Date: Sat, 20 Jun 2015 22:38:58 +0800 Message-Id: X-Mailer: git-send-email 2.3.4 In-Reply-To: <20150620103819.GA29626@sudip-PC> X-CM-TRANSID: DtGowED5+88Oe4VVhdujAA--.651S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7JF4DKF1xuw4UJryDuF48WFg_yoWxAFXE9r WktFn7uas5AFn3ur1YkFsrZrWFva1xZw4DtFn8JFsxurn0vFy8Zryv9wn7X3s5GFs3CFy7 A348tryjvFnakjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUZmR5UUUUU== X-Originating-IP: [116.77.145.190] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiNQgfmVSIHOsDDwABsd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 20, 2015 at 04:08:19PM +0530, Sudip Mukherjee wrote: > compat_ptr is already a typecast. > static inline void __user *compat_ptr(compat_uptr_t uptr) > { > return (void __user *)(unsigned long)uptr; > } > > so you are adding another typecast to an already exitsing typecast. :( > > and besides, this also introduces one new checkpatch warning of > line more than 80 char. > > regards > sudip Thank you for your review. I revised the patch as you suggested. Here it is. Geliang Tang (1): staging: comedi: fix cast warning in comedi_compat32.c drivers/staging/comedi/comedi_compat32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/