From: Geliang Tang <geliangtang@gmail.com>
To: Frank Haverkamp <haver@linux.vnet.ibm.com>,
Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Cc: Geliang Tang <geliangtang@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] Re: [PATCH] GenWQE: drop duplicate headers
Date: Mon, 28 Nov 2016 22:15:18 +0800 [thread overview]
Message-ID: <cover.1480328899.git.geliangtang@gmail.com> (raw)
In-Reply-To: <103A7FE0-12A9-4C9D-AAEF-43E84A100868@linux.vnet.ibm.com>
On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote:
> Hi Geliang,
>
> thanks for the simplification. Did you find those by manual inspection, or did you use a tool?
>
> Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
Hi Frank,
Thanks for your review.
I found those duplicate headers by a simple script written by myself.
I should have used scripts/checkincludes.pl to do this. Now I am using
scripts/checkincludes.pl to check GenWQE files, and I found another
duplicate header dma-mapping.h. So I updated this patch.
-Geliang
Geliang Tang (1):
GenWQE: drop duplicate headers
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card_ddcb.c | 1 -
drivers/misc/genwqe/card_utils.c | 2 --
3 files changed, 4 deletions(-)
--
2.9.3
next prev parent reply other threads:[~2016-11-28 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 14:24 [PATCH] dwc_eth_qos: drop duplicate headers Geliang Tang
2016-11-23 14:24 ` [PATCH] GenWQE: " Geliang Tang
2016-11-24 12:51 ` Frank Haverkamp
2016-11-28 14:15 ` Geliang Tang [this message]
2016-11-28 14:15 ` [PATCH v2] " Geliang Tang
2016-12-14 8:20 ` [PATCH] [PATCH] " Frank Haverkamp
2016-11-23 14:24 ` [PATCH] PNP: drop duplicate header pci.h Geliang Tang
2016-11-25 21:14 ` [PATCH] dwc_eth_qos: drop duplicate headers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1480328899.git.geliangtang@gmail.com \
--to=geliangtang@gmail.com \
--cc=haver@linux.vnet.ibm.com \
--cc=krisman@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).