From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753306AbdJLRAn (ORCPT ); Thu, 12 Oct 2017 13:00:43 -0400 Received: from gateway36.websitewelcome.com ([192.185.179.26]:44694 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbdJLRAm (ORCPT ); Thu, 12 Oct 2017 13:00:42 -0400 Date: Thu, 12 Oct 2017 11:15:07 -0500 From: "Gustavo A. R. Silva" To: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Oleg Drokin , Andreas Dilger , James Simmons , Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten , Eric Anholt , Stefan Wahren , Forest Bond , "Gustavo A. R. Silva" Subject: [PATCH 00/20] mark expected switch fall-throughs Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.13.173 X-Exim-ID: 1e2g8c-003z2o-S7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.175.13.173]:58162 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, this patchset aims to mark switch cases where we are expecting to fall through. In Kees Cook words: "This is an unfortunate omission in the C language, and thankfully both gcc and clang have stepped up to solve this the same way static analyzers have solved it. It does both document the intention for humans and provide a way for analyzers to report issues. Having the compiler help us not make mistakes is quite handy." In some cases there were "no break" or "fall thru" comments already in place. So I replaced them with proper "fall through" comments, which is what GCC is expecting to find. For the rest of the cases, please double check if the actual intention of the code is to fall through. Thanks! Gustavo A. R. Silva (20): staging: ks7010: ks_wlan_net: mark expected switch fall-throughs staging: lustre: lnet: socklnd: mark expected switch fall-through staging: rtl8192e: mark expected switch fall-through staging: rtl8723bs: rtw_mlme_ext: mark expected switch fall-through staging: lustre: lnet: net_fault: mark expected switch fall-through staging: comedi: s526: mark expected switch fall-through staging: rtl8188eu: usb_halinit: mark expected switch fall-through staging: vc04_services: vchiq_core: mark expected switch fall-through staging: vt6656: card: mark expected switch fall-throughs staging: rtl8188eu: usb_ops_linux: mark expected switch fall-through staging: r8822be: mark expected switch fall-throughs staging: lustre: lnet: selftest: mark expected switch fall-through staging: rtlwifi: halmac: mark expected switch fall-through staging: lustre: lnet: selftest: mark expected switch fall-throughs staging: lustre: llite: mark expected switch fall-through staging: lustre: lprocfs: mark expected switch fall-throughs staging: lustre: ldlm: mark expected switch fall-through staging: lustre: osc: mark expected switch fall-through staging: lustre: ptlrpc: mark expected switch fall-throughs staging: lustre: rpc: mark expected switch fall-throughs drivers/staging/comedi/drivers/s526.c | 5 ++--- drivers/staging/ks7010/ks_wlan_net.c | 10 ++++++++++ drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 2 +- drivers/staging/lustre/lnet/lnet/net_fault.c | 1 + drivers/staging/lustre/lnet/selftest/conctl.c | 1 + drivers/staging/lustre/lnet/selftest/module.c | 5 ++++- drivers/staging/lustre/lnet/selftest/rpc.c | 13 +++++++++---- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 1 + drivers/staging/lustre/lustre/llite/namei.c | 4 +++- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 ++++ drivers/staging/lustre/lustre/osc/osc_cache.c | 1 + drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 6 +++--- drivers/staging/rtl8188eu/hal/usb_halinit.c | 1 + drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 + drivers/staging/rtl8192e/rtllib_wx.c | 3 +-- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- .../staging/rtlwifi/halmac/halmac_88xx/halmac_api_88xx.c | 2 ++ drivers/staging/rtlwifi/halmac/rtl_halmac.c | 2 +- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 +-- drivers/staging/vt6656/card.c | 2 ++ 20 files changed, 50 insertions(+), 19 deletions(-) -- 2.7.4