From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: kyungmin.park@samsung.com, dwmw2@infradead.org,
computersforpeace@gmail.com, boris.brezillon@free-electrons.com,
marek.vasut@gmail.com, richard@nod.at,
cyrille.pitchen@wedev4u.fr
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH 0/2] mtd: onenand: samsung: Simplify code and fix leaks in error handling paths
Date: Fri, 8 Dec 2017 22:11:03 +0100 [thread overview]
Message-ID: <cover.1512765898.git.christophe.jaillet@wanadoo.fr> (raw)
The first patch converts 's3c_onenand_probe()' to devm_ functions.
This fixes a leak in one path (line 872).
This also free_irq which was not handled at all. (I hope I'm correct :) )
The 2nd patch is about an un-handled error code which looks spurious.
Not sure if I'm right.
While compile-testing it, I had to tweak the code because I don't have any
cross-compiler.
I commented the line "#include <asm/mach/flash.h>" and the compilation
succeeded. So maybe, this include is also useless.
I've left it as-is, though.
Theses patches have been compile-tested-only.
Christophe JAILLET (2):
mtd: onenand: samsung: use devm_ function to simplify code and fix
some leaks
mtd: onenand: samsung: return an error if
'mtd_device_parse_register()' fails
drivers/mtd/onenand/samsung.c | 145 ++++++++++++++----------------------------
1 file changed, 47 insertions(+), 98 deletions(-)
--
2.14.1
next reply other threads:[~2017-12-08 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 21:11 Christophe JAILLET [this message]
2017-12-08 21:11 ` [PATCH 1/2] mtd: onenand: samsung: use devm_ function to simplify code and fix some leaks Christophe JAILLET
2017-12-08 21:22 ` Boris Brezillon
2017-12-08 21:28 ` Boris Brezillon
2017-12-08 21:11 ` [PATCH 2/2] mtd: onenand: samsung: return an error if 'mtd_device_parse_register()' fails Christophe JAILLET
2017-12-08 21:24 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1512765898.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).