linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Yi <yi.z.zhang@linux.intel.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nvdimm@lists.01.org, pbonzini@redhat.com,
	dan.j.williams@intel.com, jack@suse.cz, hch@lst.de,
	yu.c.zhang@intel.com
Cc: linux-mm@kvack.org, rkrcmar@redhat.com, yi.z.zhang@intel.com,
	Zhang Yi <yi.z.zhang@linux.intel.com>
Subject: [PATCH 0/3] Fix kvm misconceives NVDIMM pages as reserved mmio
Date: Wed,  4 Jul 2018 23:30:03 +0800	[thread overview]
Message-ID: <cover.1530716899.git.yi.z.zhang@linux.intel.com> (raw)

For device specific memory space, when we move these area of pfn to
memory zone, we will set the page reserved flag at that time, some of
these reserved for device mmio, and some of these are not, such as
NVDIMM pmem.

Now, we map these dev_dax or fs_dax pages to kvm for DIMM/NVDIMM
backend, since these pages are reserved. the check of
kvm_is_reserved_pfn() misconceives those pages as MMIO. Therefor, we
introduce 2 page map types, MEMORY_DEVICE_FS_DAX/MEMORY_DEVICE_DEV_DAX,
to indentify these pages are from NVDIMM pmem. and let kvm treat these
as normal pages.

Without this patch, Many operations will be missed due to this
mistreatment to pmem pages. For example, a page may not have chance to
be unpinned for KVM guest(in kvm_release_pfn_clean); not able to be
marked as dirty/accessed(in kvm_set_pfn_dirty/accessed) etc.

Zhang Yi (3):
  kvm: remove redundant reserved page check
  mm: introduce memory type MEMORY_DEVICE_DEV_DAX
  kvm: add a function to check if page is from NVDIMM pmem.

 drivers/dax/pmem.c       |  1 +
 include/linux/memremap.h |  1 +
 virt/kvm/kvm_main.c      | 25 +++++++++++++++++--------
 3 files changed, 19 insertions(+), 8 deletions(-)

-- 
2.7.4


             reply	other threads:[~2018-07-04  6:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 15:30 Zhang Yi [this message]
2018-07-04 15:30 ` [PATCH 1/3] kvm: remove redundant reserved page check Zhang Yi
2018-07-04 15:30 ` [PATCH 2/3] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-07-04 14:50   ` Dan Williams
2018-07-05 13:20     ` zhangyi6
2018-07-04 15:30 ` [PATCH 3/3] kvm: add a function to check if page is from NVDIMM pmem Zhang Yi
2018-07-04 14:50   ` Dan Williams
2018-07-04 15:27     ` Paolo Bonzini
2018-07-04 15:25   ` Paolo Bonzini
2018-07-05 13:19     ` Zhang,Yi
2018-07-09 12:36       ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1530716899.git.yi.z.zhang@linux.intel.com \
    --to=yi.z.zhang@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=yi.z.zhang@intel.com \
    --cc=yu.c.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).