From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E97CC46464 for ; Thu, 9 Aug 2018 14:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5499621EA2 for ; Thu, 9 Aug 2018 14:34:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DlNos6HK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5499621EA2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732430AbeHIQ7x (ORCPT ); Thu, 9 Aug 2018 12:59:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:58454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730453AbeHIQ7w (ORCPT ); Thu, 9 Aug 2018 12:59:52 -0400 Received: from localhost.localdomain (c-98-220-238-81.hsd1.il.comcast.net [98.220.238.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DCE9E21E9A; Thu, 9 Aug 2018 14:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1533825281; bh=tNC0LaeTvMOzXG/M9OYmhlUUsQTlC8WSmTdU1pW1fCk=; h=From:To:Cc:Subject:Date:From; b=DlNos6HKSBtkrXaei3Gy6/nvCCa/kFc5kYal1NhmrinJ+pz7izzxW1y1XIGIya6i9 Lq/9lUUb0nUr7m9pSP/80umAj8VKu0DZgNsf6MX14wOHpvQRtjpvYFM3RQYPjqIMDn g2fl5UeB80ujR3DbL9VubX8FLL8is8pyr+zqTbWQ= From: Tom Zanussi To: rostedt@goodmis.org Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel@joelfernandes.org, mathieu.desnoyers@efficios.com, julia@ni.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions Date: Thu, 9 Aug 2018 09:34:10 -0500 Message-Id: X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Zanussi Hi, This is v3 of the hist trigger snapshot and onchange additions patchset. It's rebased on top of the latest ftrace/core and adds a few fixes to some handler/action problems I noticed while testing. v2->v3 changes: - fixed problem where trace actions were only being allowed for onmatch handlers - now trace actions can be used with any handler. - fixed problem where no action was being assigned to onmatch handlers if save or snapshot actions were specified. v1->v2 changes: - added missing tracing_cond_snapshot_data() definition for when CONFIG_TRACER_SNAPSHOT not defined - removed an unnecessary WARN_ON() in track_data_snapshot_print() Original text: This patchset adds some useful new functions to the hist trigger code: a snapshot action and an onchange handler. In order to make it easier to add these and in the process make the code more generic, I separated the code into explicit 'handlers' and 'actions', handlers being things like 'onmax' and 'onchange', and 'actions' being things like 'take a snapshot' or 'save some fields'. The first few patches do that basic refactoring, which make it easier to add the subsequent changes that arbitrarily combine actions and handlers. The fourth patch adds a 'conditional snapshot' capability that via a new tracing_snaphot_cond() function extends the existing snapshot code. It allows the caller to associate some user data with the snapshot that can be checked and saved in an update() callback whose return value determines whether the snapshot should be taken or not. The remaining patches finally add the new snapshot action and onchange handler functionality - please see those patches for details and some examples. Thanks, Tom The following changes since commit 5248ee85603067e62a228402afd2fb68f957746b: tracefs: Annotate tracefs_ops with __ro_after_init (2018-07-31 11:32:44 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/hist-snapshot-onchange-v3 Tom Zanussi (7): tracing: Refactor hist trigger action code tracing: Split up onmatch action data tracing: Generalize hist trigger onmax and save action tracing: Add conditional snapshot tracing: Move hist trigger key printing into a separate function tracing: Add snapshot action tracing: Add hist trigger onchange() handler Documentation/trace/histogram.txt | 206 +++++++ kernel/trace/trace.c | 162 +++++- kernel/trace/trace.h | 58 +- kernel/trace/trace_events_hist.c | 1008 ++++++++++++++++++++++++++--------- kernel/trace/trace_events_trigger.c | 2 +- kernel/trace/trace_sched_wakeup.c | 2 +- 6 files changed, 1163 insertions(+), 275 deletions(-) -- 2.14.1